Hi Alfusainey I tried to look at your changes and found that in some classes just every single line of code has changed. Is this really the case or do you just have some IDE settings that reformat the code automatically?
In case of the latter please make sure that you only touch lines that actually contain changes of yours otherwise it's simply impossible to perform the review. Thanks Angela From: Alfusainey Jallow <[email protected]<mailto:[email protected]>> Date: Monday 19 May 2014 01:14 To: "[email protected]<mailto:[email protected]>" <[email protected]<mailto:[email protected]>> Cc: David Buchmann <[email protected]<mailto:[email protected]>>, Angela <[email protected]<mailto:[email protected]>> Subject: Jcr-remoting server- Second POC pull request Hi all, I just sent a pull request[1] for a second proof-of-concept implementation for the jcr-remoting server- of the 'jackrabbit-jcr-server' component of jackrabbit. The current server-side implementation of the remoting is unable to write protected content to the repository, since such content needs special handling and should not be written using regular JCR API write methods. Therefore this pull request contains patch that adds functionality that would enable the jcr-remoting server be able to write protected content to the repository. In this pull request, the server does not attempt to write content by itself using the API but rather does an xml import and have the repository import the content. If, during the import, the repository detects that the content its importing is protected, it will ask its configured protected item importers to handle writing the content. So the only thing that needs to be done is to configure the repository accordingly by including the right ProtectedItemImporter that knows how to handle such protected content. Thus this implementation allows the remoting server be able to handle any sort of protected content as it makes no assumption of the underlying content repository. The advantage of this approach is that the server becomes pluggable. This way, the remoting server can sit on top of any jcr reference implementation and still be able to write custom access control content known to that repository. I modified the JsonDiffHandlerTest to include adding JR2 access control content in JSOP-format and configured the repository to include the AccessControlImporter p-i-importer. All test cases in this class should pass. If anyone has time left to review this pull request it will be much appreciate. This work is part of my master thesis and the goal is to provide AC management support for the jcr-remoting(client and server-side) and implement the PHPCR/API security package for Jackalope content repository PHP client. As this is lot of work to do, having a timely feedback will guide me to write code that is acceptable and finish my thesis on time- a strict deadline set by the University. Looking forward to your timely feedback! Best regards, Alfusainey [1] https://github.com/apache/jackrabbit/pull/18
