[
https://issues.apache.org/jira/browse/JCR-3819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172002#comment-14172002
]
Tobias Bocanegra commented on JCR-3819:
---------------------------------------
hi, thanks for the patch, but
I see a lot of unrelated changes that go beyond "code clean-up":
- why did you rename log to logger?
- why did you add 'final' modifiers? (I know why - but we usually don't use
them, because they make the code more unreadable)
- changing "synchronized" behaviors is certainly not code clean-up
- changing inheritance is certainly not code clean-up
- changing method signature (buildNodeFolderPath) is certainly not code clean-up
- in some methods, the code-flow is completely rewritten - certainly not code
clean-up
> General Code Review
> -------------------
>
> Key: JCR-3819
> URL: https://issues.apache.org/jira/browse/JCR-3819
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Affects Versions: 2.9
> Reporter: BELUGA BEHR
> Priority: Minor
> Fix For: 2.9.1
>
> Attachments: jcr_code_review.patch
>
>
> Hello,
> Attached I have made some minor clean-up, standardizing, and improvements.
> Please review. There should be no functional changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
