[
https://issues.apache.org/jira/browse/JCR-3819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173098#comment-14173098
]
BELUGA BEHR commented on JCR-3819:
----------------------------------
While I hope you consider many of the ideas proposed here, the two things in
particular to point out:
* Several of the class that get initialized through XML multiple the
configuration value by some amount but do not protect against overflows.
* For performance, consider using StringBuilder instead of StringBuffer
> Some Ideas For Improvement
> --------------------------
>
> Key: JCR-3819
> URL: https://issues.apache.org/jira/browse/JCR-3819
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Affects Versions: 2.9
> Reporter: BELUGA BEHR
> Priority: Trivial
> Fix For: 2.9.1
>
> Attachments: jcr_code_review.patch
>
>
> Hello,
> Attached I have made some minor clean-up, standardizing, and improvements.
> Please review. There should be no functional changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
