[
https://issues.apache.org/jira/browse/JCR-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251496#comment-14251496
]
angela commented on JCR-2113:
-----------------------------
Committed additional work as provided by
https://github.com/apache/jackrabbit/pull/23/files#r20943156 with revision
1646435.
[~alfu], i implemented some of the comments i added on the pull request,
however i didn't explicitly test the changes (integration tests pass but i
suspect that access control mgt is still disabled due to incomplete
configuration).
some of the modifications as follows:
- added missing license headers to new files
- dropped hardcoded paths only valid on your machine
- dropped TreeImpl and PropertyImpl and replaced it with
{{RepositoryService.createTree}} which is specific for each service impl
- the tree handled was lacking the ability to process properties present with
the tree itself... only those of the child nodes where respected.
- the access control manager test used a NamePathResolver... instead you should
use the JCR level constants as provided by javax.jcr.security.Privilege (the
client must properly resolve the qualified names to {{Name}} instances).
- as far as removal of protected nodes on the jcr-server is concerned i dropped
the usage of static methods/fields and just created an instance of
{{ProtectedRemoveManager}} upon init of the servlet.
- ...
thanks a lot for the patch... what i would like you to do in order to properly
complete your work, would be that you adjust the test-setup such that all
access control related TCK and impl-tests are run upon building the complete
jackrabbit project with {{-PintegrationTesting}}.
> JSR 283 Access Control Management
> ---------------------------------
>
> Key: JCR-2113
> URL: https://issues.apache.org/jira/browse/JCR-2113
> Project: Jackrabbit Content Repository
> Issue Type: Sub-task
> Components: jackrabbit-jcr-server, jackrabbit-jcr2spi,
> jackrabbit-spi, jackrabbit-spi-commons, jackrabbit-spi2dav,
> jackrabbit-spi2jcr, JCR 2.0
> Reporter: angela
> Assignee: angela
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
