I'd prefer not to run ITs during the release check as it potentially takes a long time. The release check process is mainly about checking the validity of the release artefacts [1]. Passing ITs should mainly be enforced by our CIs (aka OAK-2476).

Maybe a good option is to add a flag to the script so people could run ITs volunteerly.

[1] https://www.apache.org/dev/release-publishing#valid

Michael

On 5.2.15 10:37 , Davide Giannella wrote:
Hello team,

cross posting as it actually affects both jackrabbit as well as oak.
They both share the check-release.sh.

My suggestion is to add the integrationTesting profile on the check
release process to ensure a higher checks before actually providing a +1.

below a suggested (not tested yet) change on the script.

Thoughts?

Cheers
Davide

Index: check-release.sh
===================================================================
--- check-release.sh    (revision 7939)
+++ check-release.sh    (working copy)
@@ -149,10 +149,10 @@
  info ""
  info "   Running the Maven build..."
  info ""
-if (cd $ZIPDIR; exec mvn verify -Ppedantic) 2>> "$LOGFILE" 1>&2; then
-  info "   OK: mvn verify -Ppedantic"
+if (cd $ZIPDIR; exec mvn verify -Ppedantic,integrationTesting) 2>>
"$LOGFILE" 1>&2; then
+  info "   OK: mvn verify -Ppedantic,integrationTesting"
  else
-  error "  NOT OK: mvn verify -Ppedantic"
+  error "  NOT OK: mvn verify -Ppedantic,integrationTesting"
  fi
  info ""


Reply via email to