[ 
https://issues.apache.org/jira/browse/JCR-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erik Arvidson updated JCR-3850:
-------------------------------
    Description: 
The RepositoryStartupServlet in trunk (I am using release/tag 2.8.0 in testing) 
incorrectly constructs FileStore by passing 256*1024*1024 in the maxFileSizeMB 
parameter; as documented, this parameter's value is multiplied by 1048576 again 
in FileStore(BlobStore, File, NodeState, int, int, boolean) which causes the 
integer to overflow.

In my environment, the overflow caused the FileStore's maxFileSize to be 0, 
which unsurprisingly caused a crash later on in initialization of the store. A 
simple patch is attached to resolve this issue.

  was:
The RepositoryStartupServlet in trunk (I am using release/tag 2.8.0 in testing) 
incorrectly constructs FileStore by passing 256*1024*1024 in the maxFileSizeMB 
parameter; as documented, this parameter's value is multiplied by 1048576 again 
in FileStore(BlobStore, File, NodeState, int, int, boolean) which causes the 
integer to overflow.

In my environment, the overflow caused the FileStore's maxFileSize to be 0, 
which unsurprisingly caused a crash later on in initialization of the store.


> RepositoryStartupServlet constructs FileStore incorrectly
> ---------------------------------------------------------
>
>                 Key: JCR-3850
>                 URL: https://issues.apache.org/jira/browse/JCR-3850
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-webapp
>    Affects Versions: 2.8.1, 2.9.2
>            Reporter: Erik Arvidson
>             Fix For: 2.8.1, 2.9.2
>
>         Attachments: JCR-3850.patch
>
>
> The RepositoryStartupServlet in trunk (I am using release/tag 2.8.0 in 
> testing) incorrectly constructs FileStore by passing 256*1024*1024 in the 
> maxFileSizeMB parameter; as documented, this parameter's value is multiplied 
> by 1048576 again in FileStore(BlobStore, File, NodeState, int, int, boolean) 
> which causes the integer to overflow.
> In my environment, the overflow caused the FileStore's maxFileSize to be 0, 
> which unsurprisingly caused a crash later on in initialization of the store. 
> A simple patch is attached to resolve this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to