[
https://issues.apache.org/jira/browse/JCRVLT-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Bocanegra resolved JCRVLT-84.
------------------------------------
Resolution: Fixed
fixed in r1663443
> Installhook processor should not recursively call itself
> --------------------------------------------------------
>
> Key: JCRVLT-84
> URL: https://issues.apache.org/jira/browse/JCRVLT-84
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Affects Versions: 3.1.16
> Reporter: Tobias Bocanegra
> Assignee: Tobias Bocanegra
> Fix For: 3.1.18
>
>
> If an installhook fails in the prepare phase, the processor internally
> changes the phase and then re-executes. it would be cleaner if the package
> installer controls the phases. this also avoids a cast to an impl:
> {code}
> try {
> hook.getHook().execute(context);
> } catch (PackageException e) {
> // abort processing only for prepare phase
> if (context.getPhase() == InstallContext.Phase.PREPARE) {
> log.warn("Hook " + hook.name +" threw package exception.
> Prepare aborted.", e);
> 153: ((InstallContextImpl)
> context).setPhase(InstallContext.Phase.PREPARE_FAILED);
> execute(context);
> return false;
> }
> log.warn("Hook " + hook.name +" threw package exception.
> Ignored", e);
> } catch (Throwable e) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
