[
https://issues.apache.org/jira/browse/JCR-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375716#comment-14375716
]
Stefan Egli commented on JCR-3860:
----------------------------------
Reviewed the patch - looks good to me, just one comment: I'd add some javadoc
to the constructors and point out that for {{defaultValue}} it is important
that it is less than any value that wants to be measured. Ie if you want to
measure from {{0}} upwards, then {{defaultValue}} better be negative, otherwise
the algorithms dont quite work. (alternatively, you'd need paranoia checks in
the {{recordValue()}} methods to assert that {{value>=defaultValue}}
> Properly expose missing values in TimeSeries implementations
> ------------------------------------------------------------
>
> Key: JCR-3860
> URL: https://issues.apache.org/jira/browse/JCR-3860
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr-commons
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Labels: JMX, mbean, monitoring
> Fix For: 2.10.1
>
> Attachments: JCR-3860.patch
>
>
> {{TimeSeries}} implementations currently don't have a way for exposing
> missing values during an interval instead reporting {{0}}. This is
> problematic see e.g. OAK-2635.
> cc [~egli]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
