[
https://issues.apache.org/jira/browse/JCRVLT-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120767#comment-15120767
]
Marius Petria edited comment on JCRVLT-108 at 1/28/16 5:44 AM:
---------------------------------------------------------------
Hi [~tripod],
Just one question for my future knowledge :). I am not sure how your fix works
(looking at [1]). It seems that binaries are skipped by DocViewProperty (except
if they are BinaryRefs). Are they installed in another place?
EDIT: please disregard the question, I found the special binary handling in
DocViewSAXImporter [2].
[1]
http://svn.apache.org/viewvc/jackrabbit/commons/filevault/trunk/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewProperty.java?r1=1727227&r2=1727226&pathrev=1727227
[2]
https://github.com/apache/jackrabbit-filevault/blob/944fdcb23fc6707d1dd844586a2abbb26ca30d49/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L339
was (Author: mpetria):
Hi [~tripod],
Just one question for my future knowledge :). I am not sure how your fix works
(looking at [1]). It seems that binaries are skipped by DocViewProperty (except
if they are BinaryRefs). Are they installed in another place?
[1]
http://svn.apache.org/viewvc/jackrabbit/commons/filevault/trunk/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewProperty.java?r1=1727227&r2=1727226&pathrev=1727227
> Import of binaries fail because they cannot be converted to strings
> -------------------------------------------------------------------
>
> Key: JCRVLT-108
> URL: https://issues.apache.org/jira/browse/JCRVLT-108
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Affects Versions: 3.1.26
> Reporter: Marius Petria
> Assignee: Tobias Bocanegra
> Fix For: 3.1.28
>
> Attachments: JCRVLT-108.2.diff, JCRVLT-108.diff
>
>
> Importing a binary that already exists will try to compare the existing
> binary with the current value by converting it to String [1]. That fails with
> {noformat}
> (org.xml.sax.SAXException: String is too long: 2318847178994591412
> java.lang.IllegalStateException: String is too long: 2318847178994591412)
> {noformat}
> [1]
> https://github.com/apache/jackrabbit-filevault/blob/e61e618796998175dde476ed8836fecd3ce2913b/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewProperty.java#L406
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
