[ 
https://issues.apache.org/jira/browse/JCR-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389081#comment-15389081
 ] 

ASF GitHub Bot commented on JCR-3997:
-------------------------------------

GitHub user anagarwa opened a pull request:

    https://github.com/apache/jackrabbit/pull/36

    JCR-3997 TraversingItemVisitor causes stackoverflowexception with bre…

    …adth first traversal

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anagarwa/jackrabbit JCR-3997

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jackrabbit/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #36
    
----
commit 80578ec8936567348071736ee97d4cc7a356c9fd
Author: Ankit Agarwal <[email protected]>
Date:   2016-07-22T07:12:30Z

    JCR-3997 TraversingItemVisitor causes stackoverflowexception with breadth 
first traversal

----


> TraversingItemVisitor causes stackoverflowexception with breadth first 
> traversal
> --------------------------------------------------------------------------------
>
>                 Key: JCR-3997
>                 URL: https://issues.apache.org/jira/browse/JCR-3997
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-commons
>            Reporter: Chetan Mehrotra
>             Fix For: 2.13.2
>
>         Attachments: OAK-4549-test.patch
>
>
> [TraversingItemVisitor|https://docs.adobe.com/docs/en/spec/jsr170/javadocs/jcr-1.0/javax/jcr/util/TraversingItemVisitor.html]
>  when used in breadth first traversal mode can lead to StackOverflowException 
> with very flat child list. This happens because it uses recursion [1] instead 
> of plain iteration which would increase the stack size proportional to number 
> of immediate child node.
> The code technically belong to JSR-283 project. For now creating the issue 
> here
> [1] 
> https://java.net/projects/jsr-283/sources/svn/content/trunk/src/java/javax/jcr/util/TraversingItemVisitor.java?rev=967



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to