[
https://issues.apache.org/jira/browse/JCR-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15440427#comment-15440427
]
ASF GitHub Bot commented on JCR-4006:
-------------------------------------
GitHub user woonsan opened a pull request:
https://github.com/apache/jackrabbit/pull/38
JCR-4006: Fixing TestCachingFDS tests
- Add AbstractBackend.java that maintains the lifecycle of async writer
executor and initializes ImmediateExecutor when asyncWritePoolSize is 0 or
smaller.
- Change Backend implementations to extends AbstractBackend, so that each
can have an option to disable asynchronous writing.
- Change TestCachingFDS to disable asynchronous writing in unit test.
- Keep the current async writer pool size as-is for the others (for
backward compatibility).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/jackrabbit bugfix/JCR-4006
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jackrabbit/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit a8259e2a141ae7d0b9aedcb7b24638817b6e6ac8
Author: Woonsan Ko <[email protected]>
Date: 2016-08-27T00:07:30Z
JCR-4006: When async write pool size is zero or smaller, don't write
asynchronously.
commit 42f96c5d0ede9e102c49c513cc61160a7a701f90
Author: Woonsan Ko <[email protected]>
Date: 2016-08-27T00:32:14Z
JCR-4006: double-checked locking on asyncWriteExecutor. By the way, the
reason why lazy-initialization is because S3Backend and FSBackend have yet
another init() method which makes it difficult to initialize once in the
original init method.
commit bdb05c3c9e23cca6bd6083618724cbe392400674
Author: Woonsan Ko <[email protected]>
Date: 2016-08-27T01:07:06Z
JCR-4006: enable TestCachingFDS#doDeleteRecordTest() with disabling async
writing in unit test.
commit 00bdb6d4c3e06bfd0065263f1b5aeb65f51836c8
Author: Woonsan Ko <[email protected]>
Date: 2016-08-27T01:18:16Z
JCR-4006: Add homeDir and config in AbstractBackend as clean up.
----
> TestCachingFDS.testDeleteRecord() fails occasionally
> ----------------------------------------------------
>
> Key: JCR-4006
> URL: https://issues.apache.org/jira/browse/JCR-4006
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-data
> Affects Versions: 2.13.2
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Minor
> Fix For: 2.13.3
>
>
> This is the same issue as JCR-4005 but for the caching FDS in jackrabbit-data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
