[
https://issues.apache.org/jira/browse/JCR-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15440603#comment-15440603
]
ASF GitHub Bot commented on JCR-4007:
-------------------------------------
GitHub user woonsan opened a pull request:
https://github.com/apache/jackrabbit/pull/39
JCR-4007: CachingDataStore - touching in getRecord() should be done only
when GarbageCollector's marking
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/jackrabbit bugfix/JCR-4007
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jackrabbit/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit 11782d9aad416576f16b300dc2b099f09b31641f
Author: Woonsan Ko <[email protected]>
Date: 2016-08-26T22:59:06Z
make touchWhenReading optional and set it true only in S3DataStore by
default.
commit 75a0f16cfea5afcd9fe1229ce8c56db2f7c3ab6d
Author: Woonsan Ko <[email protected]>
Date: 2016-08-27T03:24:30Z
touch only when minModifiedDate set to a number greater than zero by
GarbageCollector.
----
> CachingDataStore - touching every time whenever getRecord() was unnecessary
> ---------------------------------------------------------------------------
>
> Key: JCR-4007
> URL: https://issues.apache.org/jira/browse/JCR-4007
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Affects Versions: 2.13.2
> Reporter: Woonsan Ko
> Fix For: 2.13.3
>
>
> At the moment, {{CachingDataStore#getRecord()}} always invokes
> {{#touchInternal()}}, resulting in touching the file *every time* through the
> backend whenever reading a record. This seems to cause a performance degrade
> even when cached locally.
> Touching (updating the lastModifiedDate) must not be done every time. It
> should be done only when {{minModifiedDate}} is set to a number greater than
> zero by {{org.apache.jackrabbit.core.gc.GarbageCollector}} while marking.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
