[
https://issues.apache.org/jira/browse/JCR-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478282#comment-15478282
]
Woonsan Ko edited comment on JCR-4007 at 9/9/16 9:44 PM:
---------------------------------------------------------
Please review the pull request.
I think the fix is very simple. In {{#getRecord()}} calls, the touching should
be done only when GarbageCollector is working (GarbageCollector sets
{{minModifiedDate}} to a positive number while working and resets to zero when
stopping).
was (Author: woon_san):
Please review the pull request.
I think the fix is very simple. The touching should be done only when
GarbageCollector is working (GarbageCollector sets {{minModifiedDate}} to a
positive number while working and resets to zero when stopping).
> CachingDataStore - touching every time on getRecord() was unnecessary
> ---------------------------------------------------------------------
>
> Key: JCR-4007
> URL: https://issues.apache.org/jira/browse/JCR-4007
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Affects Versions: 2.13.2
> Reporter: Woonsan Ko
> Labels: PatchAvailable
> Fix For: 2.13.4
>
>
> At the moment, {{CachingDataStore#getRecord()}} always invokes
> {{#touchInternal()}}, resulting in touching the file *every time* through the
> backend whenever reading a record. This seems to cause a performance degrade
> even when cached locally.
> Touching (updating the lastModifiedDate) must not be done every time. It
> should be done only when {{minModifiedDate}} is set to a number greater than
> zero by {{org.apache.jackrabbit.core.gc.GarbageCollector}} while marking.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
