[ 
https://issues.apache.org/jira/browse/JCR-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882664#comment-15882664
 ] 

Thomas Mueller commented on JCR-4115:
-------------------------------------

[[email protected]] just noticed, 
DataStoreTest.testDeleteRecordWithParentCollision fails. This test relies on 
SHA-1, and would need to be changed. By the way, 
testDeleteRecordWithoutParentCollision should probably also be changed, even 
thought it doesn't fail - it also relies on SHA-1.

> Don't use SHA-1 for new DataStore binaries (Jackrabbit)
> -------------------------------------------------------
>
>                 Key: JCR-4115
>                 URL: https://issues.apache.org/jira/browse/JCR-4115
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>            Reporter: Thomas Mueller
>              Labels: candidate_jcr_2_10, candidate_jcr_2_12, 
> candidate_jcr_2_14, candidate_jcr_2_4, candidate_jcr_2_6, candidate_jcr_2_8
>         Attachments: JCR-4115.patch
>
>
> A collision for SHA-1 has been published. We still use SHA-1 for the 
> FileDataStore, and I believe the S3 DataStore right now. Given there is a 
> collision, we should switch to a stronger algorithm, for example SHA-256, for 
> new binaries.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to