[ 
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907108#comment-15907108
 ] 

ASF GitHub Bot commented on JCR-4120:
-------------------------------------

GitHub user kwin opened a pull request:

    https://github.com/apache/jackrabbit/pull/51

    JCR-4120 don't assume "default" to be the default workspace name

    Improve some javadocs

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kwin/jackrabbit 
bugfix/JCR-4120-fix-default-workspace-handling

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jackrabbit/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #51
    
----
commit 308ece08285016414fa1078d2e82cb8bbaff2f52
Author: Konrad Windszus <[email protected]>
Date:   2017-03-13T10:04:12Z

    JCR-4120 don't assume "default" to be the default workspace name
    
    Improve some javadocs

----


> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to 
> "default"
> ---------------------------------------------------------------------------------------
>
>                 Key: JCR-4120
>                 URL: https://issues.apache.org/jira/browse/JCR-4120
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-spi2dav
>    Affects Versions: 2.9.1
>            Reporter: Konrad Windszus
>
> Basically the patch from JCR-2113 breaks the default workspace handling when 
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is 
> being used, because it always assumes that the default workspace name is 
> {{default}}. This is unfortunately not always true. The only reason why the 
> default workspace name need to be passed at all seems to be backwards 
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842). 
> Unfortunately the assumed default workspace name being {{default}} may lead 
> to issues, as this is then used to with each call to 
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it 
> falls back to the default workspace name when no explicit workspace name is 
> given.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to