[
https://issues.apache.org/jira/browse/JCRVLT-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000340#comment-16000340
]
Konrad Windszus commented on JCRVLT-155:
----------------------------------------
[~tripod] Thanks a lot for applying it. I am still not 100% sure that only
comparing the creation date is enough or the modified date should be considered
as well or exclusively. At least for the {{content-package-maven-plugin}} the
creation date always seems to be updated but I am not sure if you rebuild a
package within the package mananger. Could you quickly comment on that?
Thanks
> JcrPackage.isInstalled does not return false in case the package has been
> overwritten
> -------------------------------------------------------------------------------------
>
> Key: JCRVLT-155
> URL: https://issues.apache.org/jira/browse/JCRVLT-155
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 3.1.28
> Reporter: Konrad Windszus
> Fix For: 3.1.40
>
>
> Although the javadoc of {{o.a.j.v.packaging.JcrPackage#isInstalled()}} is
> stating
> bq. Checks if this package is installed. Note: the default implementation
> only checks the JcrPackageDefinition.getLastUnpacked() date. If the package
> is replaced since it was installed. this method will return false.
> this method is returning {{true}} in case the package has been reuploaded in
> between (with the same group, package name and version). This is violating
> the contract of this method.
> Please either fix implementation or javadoc description.
> That issue already lead to downstream issues in the
> {{com.adobe.granite.installer.factory.packages.impl.PackageTransformer}}
> which therefore only installs a package once.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
