[
https://issues.apache.org/jira/browse/JCRVLT-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207031#comment-16207031
]
Tobias Bocanegra edited comment on JCRVLT-209 at 10/17/17 5:30 AM:
-------------------------------------------------------------------
to recap how it works today:
- {{ workDirectory = "${project.build.directory~}/vault-work" }}
- {{ vaultDir = "${workDirectory}/META-INF/vault}" }}
- {{ filterFile = "${vaultDir}/filter.xml" }}
- the filter file is the one that will go into the package; it could happen
that the resource-plugin already copied the filter.xml there.
- if filter source exists -> merge with pom filters and write to
{{filterFile}}.
- if filter source does not exist, then special logic is applied:
-- if {{filterFile}} already exists, it is assumed that it was copied via the
resource plugin. if the generated filters from the pom is the same as the
{{filterFile}} then all is good. if it's not the same, the new filters will be
written to the {{filter-plugin-generated.xml}}
-- if {{filterFile}} does not exist, then it will use the pom filters which
will be written to the {{filterFile}}
was (Author: tripod):
to recap how it works today:
- {{ workDirectory = "${project.build.directory}/vault-work" }}
- {{ vaultDir = "${workDirectory}/META-INF/vault}" }}
- {{ filterFile = "${vaultDir}/filter.xml" }}
- the filter file is the one that will go into the package; it could happen
that the resource-plugin already copied the filter.xml there.
- if filter source exists -> merge with pom filters and write to
{{filterFile}}.
- if filter source does not exist, then special logic is applied:
-- if {{filterFile}} already exists, it is assumed that it was copied via the
resource plugin. if the generated filters from the pom is the same as the
{{filterFile}} then all is good. if it's not the same, the new filters will be
written to the {{filter-plugin-generated.xml}}
-- if {{filterFile}} does not exist, then it will use the pom filters which
will be written to the {{filterFile}}
> Always write to the filter.xml inside the vaultDir but never to
> filter-plugin-generated.xml
> -------------------------------------------------------------------------------------------
>
> Key: JCRVLT-209
> URL: https://issues.apache.org/jira/browse/JCRVLT-209
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: package maven plugin
> Reporter: Konrad Windszus
>
> Currently in case the filter configuration of the plugin has been changed and
> there is already a {{filter.xml}} in the {{vaultDir}} this is not being
> overwritten. Instead a new file named {{filter-plugin-generated.xml}} is
> being generated which is irrelevant for the package
> (https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/15baff9be241a851d4ad36e53336cec1d5613c9d/plugin/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/VaultMojo.java#L372).
> IMHO this is not a clever default behaviour because it forces to always use
> {{mvn clean}} in case of filter definition changes.
> In case someone want's to really manually modify the filter.xml the parameter
> {{filterSource}} should be used instead, but in any case the generated
> {{filter.xml}} inside the {{vaultDir}} should contain the latest generated
> filter file.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
