[
https://issues.apache.org/jira/browse/JCRVLT-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207106#comment-16207106
]
Konrad Windszus commented on JCRVLT-209:
----------------------------------------
For me {{vault-work}} is clearly a directory exclusively for the internal use
of the package plugin itself. If one really wants to use a hand-crafted
filter.xml one should(must) use the parameter {{filterSource}} which should
always point to a file outside {{vault-work}}.
Maybe to ease the pain for users which have used the plugin IMHO in the wrong
fashion in the past, we can also store in {{vault-work}} a checksum of the last
generated filter.xml. If prior to generating the new filter.xml the old content
does no longer have the same checksum we could conclude that someone manually
tweaked the filter.xml and emit an appropriate error containing some hints how
to fix this.
That is IMHO a simpler approach, easy to understand and to maintain.
> Always write to the filter.xml inside the vaultDir but never to
> filter-plugin-generated.xml
> -------------------------------------------------------------------------------------------
>
> Key: JCRVLT-209
> URL: https://issues.apache.org/jira/browse/JCRVLT-209
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: package maven plugin
> Reporter: Konrad Windszus
>
> Currently in case the filter configuration of the plugin has been changed and
> there is already a {{filter.xml}} in the {{vaultDir}} this is not being
> overwritten. Instead a new file named {{filter-plugin-generated.xml}} is
> being generated which is irrelevant for the package
> (https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/15baff9be241a851d4ad36e53336cec1d5613c9d/plugin/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/VaultMojo.java#L372).
> IMHO this is not a clever default behaviour because it forces to always use
> {{mvn clean}} in case of filter definition changes.
> In case someone want's to really manually modify the filter.xml the parameter
> {{filterSource}} should be used instead, but in any case the generated
> {{filter.xml}} inside the {{vaultDir}} should contain the latest generated
> filter file.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
