[ https://issues.apache.org/jira/browse/JCR-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251169#comment-16251169 ]
Vikas Saurabh commented on JCR-4213: ------------------------------------ [~reschke], bq. Does this have to be done before we branch 2.16? (Scheduled Nov 20) I'm almost convinced that we don't need this at all - but if we do, then yes, it would need to be done before the cut (so, that it can be included in OAK-6925). > It is useful to return an error code with DataStoreException when a record is > not found > --------------------------------------------------------------------------------------- > > Key: JCR-4213 > URL: https://issues.apache.org/jira/browse/JCR-4213 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-data > Reporter: Vikas Saurabh > Assignee: Vikas Saurabh > Priority: Minor > Fix For: 2.16 > > Attachments: JCR-4213.patch > > > To help with cases like OAK-6935, it would be useful if > {{DataStoreException}}, on best effort basis, provides and error code too. > An example stack that OAK-6935 logs currently looks like: > {noformat} > .... > org.apache.jackrabbit.oak.plugins.index.lucene.directory.ActiveDeletedBlobCollectorFactory$ActiveDeletedBlobCollectorImpl > Exception occurred while attempting to delete blob > df38cfbdccbe27dba778679befd74b10e40c3eb46f96e58ee4bb6c2c6b993d3f#4694 > org.apache.jackrabbit.core.data.DataStoreException: Record > df38cfbdccbe27dba778679befd74b10e40c3eb46f96e58ee4bb6c2c6b993d3f does not > exist > at > org.apache.jackrabbit.core.data.AbstractDataStore.getRecord(AbstractDataStore.java:58) > at > org.apache.jackrabbit.oak.plugins.blob.datastore.OakFileDataStore.getRecordForId(OakFileDataStore.java:259) > at > org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStore.getRecordForId(DataStoreBlobStore.java:519) > at > org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStore.countDeleteChunks(DataStoreBlobStore.java:425) > at > org.apache.jackrabbit.oak.plugins.index.lucene.directory.ActiveDeletedBlobCollectorFactory$ActiveDeletedBlobCollectorImpl.purgeBlobsDeleted(ActiveDeletedBlobCollectorFactory.java:224) > at > org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexProviderService.lambda$initializeActiveBlobCollector$0(LuceneIndexProviderService.java:760) > ... > ... > {noformat} > /cc [~amjain] -- This message was sent by Atlassian JIRA (v6.4.14#64029)