[ 
https://issues.apache.org/jira/browse/JCRVLT-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270645#comment-16270645
 ] 

Stefan Seifert commented on JCRVLT-240:
---------------------------------------

bq. IIUC you patch correctly, it always overwrites the .content.xml, which 
should only happen if it doesn't exist yet.
checked again - this is not the case. the helper method {{copyFile}] does 
nothing if the target already exists.

what is always copied is the thumbnail image - if it is set in the plugin 
config explicitly and exists.

> Package Maven Plugin: Support for package thumbnails
> ----------------------------------------------------
>
>                 Key: JCRVLT-240
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-240
>             Project: Jackrabbit FileVault
>          Issue Type: New Feature
>          Components: package maven plugin
>    Affects Versions: package-maven-plugin-1.0.0
>            Reporter: Stefan Seifert
>             Fix For: package-maven-plugin-1.0.1
>
>         Attachments: JCRVLT-240.patch
>
>
> adding package thumbnails for the generated packages is a but cumbersome 
> currently - one has to know exactly the internal path of the thumbnail image 
> in the package format, and also add a ".content.xml" in the definition folder.
> it would be nice to have a "thumbnailImage" parameter which accepts a path to 
> a thumbnail PNG file - and does the correct placement in the folder and 
> generation of the ".content.xml" then automatically.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to