Tobias Bocanegra updated JCRVLT-255:
    Fix Version/s:     (was: 3.1.44)

I looked into the issue and it seems that MERGE is only supported for generic 
artifacts of authorizable and policy nodes. it also supports merging of entire 

- but not for file artifacts with content; eg: image.png.dir/.content.xml
- but not for all generic artifacts

since this change would be a bit more complicated and need extensive test and 
has potentially backward compatibility implications, I decided to more this to 
the 3.2 release and document  the current behaviour.

> ImportModes act on file serialization level not on node level
> -------------------------------------------------------------
>                 Key: JCRVLT-255
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-255
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: Packaging
>            Reporter: Konrad Windszus
>            Priority: Major
>             Fix For: 3.2
> When reading the docs at 
> http://jackrabbit.apache.org/filevault/importmode.html I would assume that 
> for {{ImportMode.MERGE}} the merging happens on node level (i.e. indepent of 
> the actual serialization format). Unfortunately this is not the case: If I 
> have a serialized docview {{.content.xml}} file covering the current node and 
> three levels below the merging is not done if the entry node level does 
> already exist in the repository, although not all child nodes are in the 
> repository yet.
> This is due to the guard in 
> https://github.com/apache/jackrabbit-filevault/blob/8b2fedaf329b3bf4a049e41563c0bc83487406f7/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/FileArtifactHandler.java#L226.
>  which prevents the DocViewSAXImporter from kicking in, although there are 
> indeed subnodes in the {{.content.xml}} which are not yet in the repository.
> Please either fix this behaviour of make the documentation at 
> http://jackrabbit.apache.org/filevault/importmode.html clearer because it 
> explicitly says there:
> {quote}
> It is important to note, that the import mode always operates on entire nodes 
> and subtrees...
> {quote}

This message was sent by Atlassian JIRA

Reply via email to