[ 
https://issues.apache.org/jira/browse/JCRVLT-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366416#comment-16366416
 ] 

Tobias Bocanegra commented on JCRVLT-271:
-----------------------------------------

bq. Is there a reliable way to calculate the same order of the properties as 
for the case of a push/pull roundtrip with FileVault

The attribute order of the DocView is not specified by the JCR spec. 
Vault uses the {{org.apache.jackrabbit.vault.util.ItemNameComparator}} which 
sorts the properties by namespace prefix fist, and then on property name. It 
further has a special line-break and indentation rule, by putting each 
attribute on a new line, which makes it more easy to diff. this is implemented 
somewhere in {{org.apache.jackrabbit.vault.util.xml.serialize.XMLSerializer}}

[~diru] IIRC, you still haven't signed a CLA yet and are not a committer 
(http://people.apache.org/unlistedclas.html). see 
https://www.apache.org/licenses/. Your patch is beyond a quick fix, so I think 
a CLA is required.




> Support a CLI command to format vault xml files
> -----------------------------------------------
>
>                 Key: JCRVLT-271
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-271
>             Project: Jackrabbit FileVault
>          Issue Type: New Feature
>          Components: Misc
>            Reporter: Dirk Rudolph
>            Priority: Major
>
> In our projects we work with vlt IDE integrations (Intellij and Eclpise) to 
> have an easy and feature rich development process. On the other hand there 
> are situations where we are writing vlt xml files manually. To not have huge 
> diffs of formatting changes we tend to commit those vlt xml files formatted 
> in the way as they are produced by exporting the corresponding nodes from a 
> remote repository.
> Unfortunately the format can not fully be achieved by formatting using the 
> build in xml formatters of the IDE, nor am I aware of any tooling that would 
> allow us to check the formatting using lets say a commit hook or maven 
> plugin. So the common approach we use at the moment is to push and afterwards 
> pull nodes to or from the remote repository. 
> To improve that, only formatting the local files with the format the export 
> uses is much more efficient and can also be automated. 
> This is a proposal to introduce a _format_ command for the vlt-cli that:
>  * accepts a list of file patterns that should be processed in the current 
> directory tree
>  * formats each file included by the patterns or
>  * checks if the file is in the right format and fails if not with a list of 
> all malformed files
> This can then be used to:
>  * automatically format by cli invocation
>  * validate the format during build or as pre commit hook



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to