[ 
https://issues.apache.org/jira/browse/JCRVLT-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423987#comment-16423987
 ] 

Konrad Windszus commented on JCRVLT-246:
----------------------------------------

To be able to run some kind of validation in incremental builds it is often 
crucial to have the metadata of the packages at hand. That is impossible if the 
metadata is generated in the same goal as the package itself, as e.g. m2e will 
never execute the phase "package" during incremental builds for performance 
reasons. For another concrete example just look at 
https://issues.apache.org/jira/browse/SLING-6344. In the Sling IDE we want to 
rely on filter files being generated by this plugin.

Regarding your comment
bq.  it really rips the entire logic apart and results in spaghetti code with 
weird dependencies between the mojos.

That depends a bit on the perspective I guess. I would argue that separating 
the packaging from the metadata generation makes the code in general a bit 
cleaner. But of course there are some properties which are being used for both 
goals. Also the file map needs to be passed from one goal to the other, but 
this is similar to the import packages which are right now also being 
calculated in a dedicated goal (the only difference is that those are being 
passed as generated file and not as Maven properties)

> Generate metadata like filter.xml and properties.xml in dedicated goal
> ----------------------------------------------------------------------
>
>                 Key: JCRVLT-246
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-246
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>          Components: package maven plugin
>    Affects Versions: package-maven-plugin-1.0.0
>            Reporter: Konrad Windszus
>            Priority: Major
>
> To support IDE integration better it would be beneficial if all the metadata 
> for content-packages (like filter.xml or properties.xml) would be generated 
> in a dedicated goal (by default bound to phase generate-resources). That goal 
> should also support m2e integration 
> (http://www.eclipse.org/m2e/documentation/m2e-making-maven-plugins-compat.html).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to