[ https://issues.apache.org/jira/browse/JCRVLT-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konrad Windszus updated JCRVLT-289: ----------------------------------- Status: Patch Available (was: Open) PR: https://github.com/apache/jackrabbit-filevault/pull/26 > InstallHooks: Propagate exceptions also for phase INSTALL > --------------------------------------------------------- > > Key: JCRVLT-289 > URL: https://issues.apache.org/jira/browse/JCRVLT-289 > Project: Jackrabbit FileVault > Issue Type: New Feature > Components: Packaging > Affects Versions: 3.1.44 > Reporter: Konrad Windszus > Priority: Major > > Currently only exceptions in phase {{PREPARE}} lead to a failure on the > client side > (https://github.com/apache/jackrabbit-filevault/blob/a64860257de2450f804b0cdf55a5afc8686b2636/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/InstallHookProcessorImpl.java#L150). > But also errors in phase {{lifecyle}} should be propagated to the called, > otherwise the caller cannot know whether the execution of the hook was > successful or not. > Therefore, exceptions in that phase within > InstallHookProcessorImpl.execute(...) should also lead to a return value of > {{false}}. In addition the return value needs to be evaluated in > https://github.com/apache/jackrabbit-filevault/blob/9eb53d36adfb7695a44075c72ca7ff0cedafabcc/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/ZipVaultPackage.java#L241. -- This message was sent by Atlassian JIRA (v7.6.3#76005)