[
https://issues.apache.org/jira/browse/JCR-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515900#comment-16515900
]
Konrad Windszus edited comment on JCR-3211 at 6/18/18 3:52 PM:
---------------------------------------------------------------
[~reschke] This would work if you rely on System properties. I can image though
there are some use cases where you rather want to configure that through
explicit parameters. Is it possible to add parameters to
[https://github.com/apache/jackrabbit/blob/40fef0a1940af9b89a5f1126ee1c3f48399aad0d/jackrabbit-spi2dav/src/main/java/org/apache/jackrabbit/spi2davex/Spi2davexRepositoryServiceFactory.java#L72]
similar to {{PARAM_MAX_CONNECTIONS}} which allows to configure a proxy.
A concrete use case for that would be vlt-rcp or the Sling IDE
([https://github.com/apache/sling-ide-tooling/blob/cc6da107f2bb381a76e9cf13374a8090dc4e5f77/shared/modules/impl-vlt/src/main/java/org/apache/sling/ide/jcr/RepositoryUtils.java#L83]),
currently uses the actual factory implementation from FileVault
([https://github.com/apache/jackrabbit-filevault/blob/0dcf09d58fa40cbe3bc24dcb6a00281123bd5a1c/vault-davex/src/main/java/org/apache/jackrabbit/vault/davex/DAVExRepositoryFactory.java#L70]).
For the latter it would be nice if the proxy settings from within Eclipse
could be configured to be used (programmatically in the Sling IDE source code).
The according API for retrieving the configured proxy in Eclipse looks like
this:
[https://help.eclipse.org/neon/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fcore%2Fnet%2Fproxy%2FIProxyService.html].
It would be nice to support the following proxy parametrisation
- Type: SOCKS, HTTPS, HTTP
- Host
- Port
- optionally Password
- optionally Username
(compare with
[https://help.eclipse.org/neon/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fcore%2Fnet%2Fproxy%2FIProxyData.html])
I guess this would cover pretty much all use cases.
was (Author: kwin):
[~reschke] This would work if you rely on System properties. I can image though
there are some use cases where you rather want to configure that through
explicit parameters. Is it possible to add parameters to
[https://github.com/apache/jackrabbit/blob/40fef0a1940af9b89a5f1126ee1c3f48399aad0d/jackrabbit-spi2dav/src/main/java/org/apache/jackrabbit/spi2davex/Spi2davexRepositoryServiceFactory.java#L72]
similar to {{PARAM_MAX_CONNECTIONS}} which allows to configure a proxy.
A concrete use case for that would be vlt-rcp or the Sling IDE
([https://github.com/apache/sling-ide-tooling/blob/cc6da107f2bb381a76e9cf13374a8090dc4e5f77/shared/modules/impl-vlt/src/main/java/org/apache/sling/ide/jcr/RepositoryUtils.java#L83]),
currently uses the actual factory implementation from FileVault
(https://github.com/apache/jackrabbit-filevault/blob/0dcf09d58fa40cbe3bc24dcb6a00281123bd5a1c/vault-davex/src/main/java/org/apache/jackrabbit/vault/davex/DAVExRepositoryFactory.java#L70).
For the latter it would be nice if the proxy settings from within Eclipse
could be configured to be used (programmatically in the Sling IDE source code).
The according API for retrieving the configured proxy in Eclipse looks like
this:
[https://help.eclipse.org/neon/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fcore%2Fnet%2Fproxy%2FIProxyService.html].
It would be nice to support the following proxy data per host (maybe with some
wildcard matching)
- Type: SOCKS, HTTPS, HTTP
- Host
- Port
- optionally Password
- optionally Username
(compare with
[https://help.eclipse.org/neon/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fcore%2Fnet%2Fproxy%2FIProxyData.html])
I guess this would cover pretty much all use cases.
> Support HTTP proxy in SPI2DAV
> -----------------------------
>
> Key: JCR-3211
> URL: https://issues.apache.org/jira/browse/JCR-3211
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-spi2dav
> Affects Versions: 2.2.10
> Reporter: Warren Janssens
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JCR-3211.diff
>
>
> There needs to be a way to configure a proxy and proxy credentials on the
> HttpClient HostConfiguration and State objects in RepositoryServiceImpl to
> enable requests over HTTP proxies.
> Ideally the configuration could be done without resorting to static or thread
> local values.
> The workaround is to use a proxy servlet that has the real endpoint of the
> repository hardcoded so it's not that critical of a bug but this workaround
> may not always be an available option.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
