[
https://issues.apache.org/jira/browse/JCR-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550372#comment-16550372
]
Julian Reschke commented on JCR-4335:
-------------------------------------
It's a bit unfortunate to have a complex API addition here, but no actual
implementation or tests (I understand that's in Oak, but still...).
That said:
- there are a few cases where null is returned when something isn't available;
AFAIR in the JCR API we usually throw UnsupportedOperationsExceptions instead
(so this is a consistency thing)
- terminology: "MIME type" should be "(internet) media type" and "encoding"
should be "character encoding". (Yes, the JCR properties have somewhat
misleading names)
- the claim that the encoding doesn't matter for non-text types is not really
true. For instance "application/xml" has a charset parameter, but "text/vcard"
does not
- it's unclear to me how the choice of disposition type can be made by the user
of the API (as opposed to, for instance, a system-wide policy)
Furthermore it seems to me that the whole API surface is big but still leaves
essential information out. Such as:
- do we really need to parametrize sizes and number of parts? I understand that
the implementation doing the upload needs this, but why does it appear in the
API?
- the API currently returns a set of upload URIs, but is completely silent
about how to use them
> API for direct binary access
> ----------------------------
>
> Key: JCR-4335
> URL: https://issues.apache.org/jira/browse/JCR-4335
> Project: Jackrabbit Content Repository
> Issue Type: New Feature
> Components: jackrabbit-api
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Major
> Attachments: JCR-4335.patch, JCR-4335.patch
>
>
> Jackrabbit Oak proposes to add a new direct binary access capability to the
> repository. One part of the proposal is to expose this new capability in the
> Jackrabbit API. For details see OAK-7569 and OAK-7589.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
