[ 
https://issues.apache.org/jira/browse/JCRVLT-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576322#comment-16576322
 ] 

Konrad Windszus edited comment on JCRVLT-288 at 8/11/18 10:15 AM:
------------------------------------------------------------------

After upgrading the PR 
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/15 to 
the FileVault 3.2.0 (release version) I get the following failures in some ITs
{code}
[INFO] Running org.apache.jackrabbit.filevault.maven.packaging.it.FilterIT
[ERROR] Tests run: 13, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 59.063 
s <<< FAILURE! - in org.apache.jackrabbit.filevault.maven.packaging.it.FilterIT
[ERROR] 
test_merge_inline_filter_with_metainf(org.apache.jackrabbit.filevault.maven.packaging.it.FilterIT)
  Time elapsed: 7.496 s  <<< FAILURE!
org.junit.ComparisonFailure: 
filter.xml is correct expected:<...
    <filter root="/[apps/test"/>
    <filter root="/]libs/foo" type="clea...> but was:<...
    <filter root="/[]libs/foo" type="clea...>
        at 
org.apache.jackrabbit.filevault.maven.packaging.it.FilterIT.verify(FilterIT.java:39)
        at 
org.apache.jackrabbit.filevault.maven.packaging.it.FilterIT.test_merge_inline_filter_with_metainf(FilterIT.java:95)

[ERROR] 
test_merge_inline_filter(org.apache.jackrabbit.filevault.maven.packaging.it.FilterIT)
  Time elapsed: 3.825 s  <<< FAILURE!
org.junit.ComparisonFailure: 
filter.xml is correct expected:<...
    <filter root="/[apps/test"/>
    <filter root="/]libs/foo" type="clea...> but was:<...
    <filter root="/[]libs/foo" type="clea...>
        at 
org.apache.jackrabbit.filevault.maven.packaging.it.FilterIT.verify(FilterIT.java:39)
        at 
org.apache.jackrabbit.filevault.maven.packaging.it.FilterIT.test_merge_inline_filter(FilterIT.java:87)
{code}

The expected filter.xml looks like this
{code}
<?xml version="1.0" encoding="UTF-8"?>
<workspaceFilter version="1.0">
    <filter root="/apps/test"/>
    <filter root="/libs/foo" type="cleanup"/>
    <filter root="/libs/bar" mode="merge">
        <include pattern="/libs/bar/a"/>
        <include pattern="/libs/bar/b/.*"/>
        <exclude pattern="/libs/bar/foo(/.*)?"/>
    </filter>
</workspaceFilter>
{code}

while the actual filter.xml looks with FileVault 3.2.0 like this
{code}
<?xml version="1.0" encoding="UTF-8"?>
<workspaceFilter version="1.0">
    <filter root="/libs/foo" type="cleanup"/>
    <filter root="/libs/bar" mode="merge">
        <include pattern="/libs/bar/a"/>
        <include pattern="/libs/bar/b/.*"/>
        <exclude pattern="/libs/bar/foo(/.*)?"/>
    </filter>
</workspaceFilter>
{code}

So the entry from the filter.xml given via {{META-INF/vault/filter.xml}} is 
simply missing.

[~tripod] Can you check whether there is a regression in FileVault 3.2.0 with 
regards to filter merging?


was (Author: kwin):
After upgrading the PR 
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/15 to 
the FileVault 3.2.0 (release version) I get the following failures in some ITs
{code}
[INFO] Running org.apache.jackrabbit.filevault.maven.packaging.it.FilterIT
[ERROR] Tests run: 13, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 59.063 
s <<< FAILURE! - in org.apache.jackrabbit.filevault.maven.packaging.it.FilterIT
[ERROR] 
test_merge_inline_filter_with_metainf(org.apache.jackrabbit.filevault.maven.packaging.it.FilterIT)
  Time elapsed: 7.496 s  <<< FAILURE!
org.junit.ComparisonFailure: 
filter.xml is correct expected:<...
    <filter root="/[apps/test"/>
    <filter root="/]libs/foo" type="clea...> but was:<...
    <filter root="/[]libs/foo" type="clea...>
        at 
org.apache.jackrabbit.filevault.maven.packaging.it.FilterIT.verify(FilterIT.java:39)
        at 
org.apache.jackrabbit.filevault.maven.packaging.it.FilterIT.test_merge_inline_filter_with_metainf(FilterIT.java:95)

[ERROR] 
test_merge_inline_filter(org.apache.jackrabbit.filevault.maven.packaging.it.FilterIT)
  Time elapsed: 3.825 s  <<< FAILURE!
org.junit.ComparisonFailure: 
filter.xml is correct expected:<...
    <filter root="/[apps/test"/>
    <filter root="/]libs/foo" type="clea...> but was:<...
    <filter root="/[]libs/foo" type="clea...>
        at 
org.apache.jackrabbit.filevault.maven.packaging.it.FilterIT.verify(FilterIT.java:39)
        at 
org.apache.jackrabbit.filevault.maven.packaging.it.FilterIT.test_merge_inline_filter(FilterIT.java:87)
{code}
[~tripod] Can you check whether there is a regression in FileVault 3.2.0 with 
regards to filter merging?

> Support XML Docview formatting in a dedicated goal
> --------------------------------------------------
>
>                 Key: JCRVLT-288
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-288
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>          Components: package maven plugin
>    Affects Versions: package-maven-plugin-1.0.1
>            Reporter: Konrad Windszus
>            Priority: Major
>             Fix For: package-maven-plugin-1.0.2
>
>
> There should be a dedicated goal which either formats XML files according to 
> the Jackrabbit Filevault Docview XML format or only check if files are 
> compliant with that format (e.g. for CI servers). The goal should support m2e 
> properly (i.e. support emitting error messages or reformatting source files 
> in an incremental build)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to