[
https://issues.apache.org/jira/browse/JCR-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated JCR-4291:
--------------------------------
Comment: was deleted
(was: trunk: [r1830540|http://svn.apache.org/r1830540]
2.16: [r1831722|http://svn.apache.org/r1831722]
2.14: [r1833731|http://svn.apache.org/r1833731]
)
> FileInputStream for workspace.xml not closed in
> RepositoryConfig.loadWorkspaceConfig(File)
> ------------------------------------------------------------------------------------------
>
> Key: JCR-4291
> URL: https://issues.apache.org/jira/browse/JCR-4291
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: config
> Affects Versions: 2.17.2
> Reporter: Jan Quadflieg
> Assignee: Julian Reschke
> Priority: Trivial
> Labels: candidate_jcr_2_10
> Fix For: 2.18, 2.16.2, 2.17.3, 2.14.6, 2.12.10
>
> Attachments: RepositoryConfig.patch
>
>
> As already said in the summary: The FileInputStream in
> RepositoryConfig.loadWorkspaceConfig(File) is not closed. This open file
> handle prevents the repository from being deleted (we use a simple
> TransientRepository in unit tests which gets deleted after each test). The
> obvious fix is simple:
> {color:#d04437}Buggy Code:{color}
> {code:java}
> try {
> File file = new File(directory, WORKSPACE_XML);
> InputSource xml = new InputSource(new FileInputStream(file));
> // ...
> } catch (FileNotFoundException e) {
> return null;
> }
> {code}
> {color:#14892c}Fixed Code:{color}
> {code:java}
> FileInputStream fin = null;
> try {
> File file = new File(directory, WORKSPACE_XML);
> fin = new FileInputStream(file);
> InputSource xml = new InputSource(fin);
> // ...
> } catch (FileNotFoundException e) {
> return null;
> } finally {
> IOUtils.closeQuietly(fin);
> }
> {code}
> The attached patch file has been created from the 2.17.2 source.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
