[ 
https://issues.apache.org/jira/browse/JCRVLT-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685024#comment-16685024
 ] 

Konrad Windszus commented on JCRVLT-279:
----------------------------------------

Understood. The question is whether the approach b) only is fine for the 
filevault-package-maven-plugin or whether we should also support a). In case b) 
is fine, the attached PR should be ready to merge IMHO.

> Emit warning/error in case embedded file/subpackage is overwritten by 
> jcrRootSourceDirectory
> --------------------------------------------------------------------------------------------
>
>                 Key: JCRVLT-279
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-279
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: package maven plugin
>    Affects Versions: package-maven-plugin-1.0.1
>            Reporter: Konrad Windszus
>            Priority: Minor
>             Fix For: package-maven-plugin-1.0.4
>
>
> Due to errorneous project setup it may sometimes happen that the 
> {{jcrRootSourceDirectory}} inadvertently contains the to be embedded file. 
> Since the {{jcrRootSourceDirectory}} is having a higher precedence all files 
> in there overwrite previously embedded files. In that case a warning/error 
> should be emitted. The same for sub packages.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to