[
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686749#comment-16686749
]
Konrad Windszus edited comment on JCR-4120 at 11/14/18 3:52 PM:
----------------------------------------------------------------
I don't know that code enough to either provide tests nor to answer whether
non-davex is affected as well. But the whole PR comes from the discussion in
https://issues.apache.org/jira/browse/JCR-2113?focusedCommentId=15760326&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15760326
so I assume [~anchela] should know.
For me the main driver is https://issues.apache.org/jira/browse/SLING-6618,
where we implemented now the nasty workaround of hardcoding the default
workspace name (in
http://svn.apache.org/viewvc/sling/trunk/tooling/ide/impl-vlt/src/org/apache/sling/ide/jcr/RepositoryUtils.java?r1=1706960&r2=1790374&pathrev=1790374).
[~tripod] was forced to use a similar nasty hardcoding in
https://github.com/apache/jackrabbit-filevault/commit/50c8754de2df6e9fdabbdb4ab60945120bf1bbdf.
IMHO no client should ever be forced to provide an explicit workspace name if
the default is meant (especially not if Oak is the underlying repo which
doesn't even support workspaces!)
was (Author: kwin):
I don't know that code enough to either provide tests nor to answer whether
non-davex is affected as well. But the whole PR comes from the discussion in
https://issues.apache.org/jira/browse/JCR-2113?focusedCommentId=15760326&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15760326
so I assume [~anchela] should know.
For me the main driver is https://issues.apache.org/jira/browse/SLING-6618,
where we implemented now the nasty workaround of hardcoding the default
workspace name (in
http://svn.apache.org/viewvc/sling/trunk/tooling/ide/impl-vlt/src/org/apache/sling/ide/jcr/RepositoryUtils.java?r1=1706960&r2=1790374&pathrev=1790374).
[~tripod] was forced to use a similar nasty hardcoding in
https://github.com/apache/jackrabbit-filevault/commit/50c8754de2df6e9fdabbdb4ab60945120bf1bbdf.
> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to
> "default"
> ---------------------------------------------------------------------------------------
>
> Key: JCR-4120
> URL: https://issues.apache.org/jira/browse/JCR-4120
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-spi2dav
> Reporter: Konrad Windszus
> Priority: Major
>
> Basically the patch from JCR-2113 breaks the default workspace handling when
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is
> being used, because it always assumes that the default workspace name is
> {{default}}. This is unfortunately not always true. The only reason why the
> default workspace name need to be passed at all seems to be backwards
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842).
> Unfortunately the assumed default workspace name being {{default}} may lead
> to issues, as this is then used to with each call to
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it
> falls back to the default workspace name when no explicit workspace name is
> given.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
