[ https://issues.apache.org/jira/browse/JCR-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794603#comment-16794603 ]
Woonsan Ko edited comment on JCR-4401 at 3/17/19 10:20 PM: ----------------------------------------------------------- Merged PR: https://github.com/apache/jackrabbit/pull/82 ----- Added a new submodule, jackrabbit-standalone-components, which contains most of the dependencies and classes and resource, while jackrabbit-standalone includes all of those transitively through jackrabbit-standalone-components. I've used this, jackrabbit-standalone-components in the new webdav4 provider of Commons VFS. Everything seems working fine now. I made a pull request there for review purpose for now: https://github.com/apache/commons-vfs/pull/52 By the way, I've made two changes in the standalone Main class for the cases where unit tests starts a Jackrabbit standalone {{Main}}: - Make {{#run}} public, so unit tests can easily instantiate and start it. - Add #shutdown as public, so unit tests can make a graceful shutdown before JVM shutdown hook takes the place. was (Author: woon_san): Merged PR: https://github.com/apache/jackrabbit/pull/82 ----- Added a new submodule, jackrabbit-standalone-components, which contains most of the dependencies and classes and resource, while jackrabbit-standalone includes all of those transitively through jackrabbit-standalone-components. I've used this, jackrabbit-standalone-components in the new webdav4 provider of Commons VFS. Everything seems working fine now. I made a pull request there for review purpose for now: apache/commons-vfs#52 By the way, I've made two changes in the standalone Main class for the cases where unit tests starts a Jackrabbit standalone {{Main}}: - Make {{#run}} public, so unit tests can easily instantiate and start it. - Add #shutdown as public, so unit tests can make a graceful shutdown before JVM shutdown hook takes the place. > Split jackrabbit-standalone to jackrabbit-standalone-components and the rest > ---------------------------------------------------------------------------- > > Key: JCR-4401 > URL: https://issues.apache.org/jira/browse/JCR-4401 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-standalone > Affects Versions: 2.19.0 > Reporter: Woonsan Ko > Assignee: Woonsan Ko > Priority: Major > > I'd like to help fix VFS-686 [1] by upgrading JR dependency from 1.6.5 to the > latest of 2.x for the WebDAV vfs provider. The fix will allow to use WebDAV > DataStore backend again. (Since JR upgraded httpclient to v4.x, WebDAV > backend has been broken.) > One problem is that the test case for WebDAV vfs provider counts on > jackrabbit-standalone dependency--to start an extended JR Main for > testing--which has been unavailable in maven repos for long time. It's > understandable not to deploy the module as it's too big. > At the same time, it would be awkward if VFS should contain all the necessary > JR dependencies as jackrabbit-standalone does. > I think it would be nice if we split the module, by moving all the Java > classes and resources with most dependencies, except of jackrabbit-webapp, to > a new maven module (e.g, "jackrabbit-standalone-components") and having > dependency on this new module and webapp module in jackrabbit-standalone > bundle module. This will let VFS keep the JR dependencies simple and easy. > \[1\] https://issues.apache.org/jira/browse/VFS-686 -- This message was sent by Atlassian JIRA (v7.6.3#76005)