[ 
https://issues.apache.org/jira/browse/JCRVLT-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934619#comment-16934619
 ] 

Konrad Windszus edited comment on JCRVLT-378 at 9/20/19 6:07 PM:
-----------------------------------------------------------------

HI [~madamcin]
Thanks for your input. I was aware of the implicit exclude, but it is 
explicitly stated in 
https://jackrabbit.apache.org/filevault/filter.html#Usage_for_Export
bq. It is important to know, that only the nodes that match the filter are 
actually traversed, which can lead to unexpected results.

So I would expect that in case {{filter.contains("/var/acs-commons")}} returns 
{{false}}. for above filter it would not descend into child nodes because the 
parent node does not match in the first place.

That would mean that in almost all cases I would have to add for a whitelisting 
pattern the root node path itself as first include to make sure the  child 
nodes are really included in the export.


was (Author: kwin):
HI [~madamcin]
Thanks for your input. I was aware of the implicit exclude, but it is 
explicitly stated in 
https://jackrabbit.apache.org/filevault/filter.html#Usage_for_Export
bq. It is important to know, that only the nodes that match the filter are 
actually traversed, which can lead to unexpected results.

So I would expect that in case {{filter.contains("/var/acs-commons")}} returns 
{{false}}. for above filter it would not descend into child nodes because the 
parent node does not match in the first place.

> WorkspaceFilter.contains return false negative
> ----------------------------------------------
>
>                 Key: JCRVLT-378
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-378
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: vlt
>            Reporter: Konrad Windszus
>            Priority: Major
>
> For this workspace filter
> {code}
> <filter root="/var/acs-commons">
>         <include pattern="/var/acs-commons/httpcache"/>
>         <include pattern="/var/acs-commons/httpcache/root"/>
> </filter>
> {code}
> The call of {{WorkspaceFilter.contains("/var/acs-commons")}} returns 
> {{false}}.
> This is unexpected because this is the root path itself.
> So this node should be installed (including all direct properties) and only 
> sub nodes are being filtered with the includes/excludes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to