[
https://issues.apache.org/jira/browse/JCRVLT-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16965688#comment-16965688
]
Konrad Windszus edited comment on JCRVLT-354 at 11/3/19 4:24 PM:
-----------------------------------------------------------------
I proposed a fix in http://svn.apache.org/r1869339 and deployed a new snapshot.
I now only get the following warning on your sample project:
{code}
INFO] --- filevault-package-maven-plugin:1.0.5-SNAPSHOT:validate-package
(default-validate-package) @ mycompany.myprojectgroup.myproject1.sample-content
---
[INFO] Start validating package
'/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/sample-content/target/myproject1-sample-content-1.0.0-SNAPSHOT.zip'...
[INFO] Using 9 validators for package of type CONTENT: jackrabbit-filter
(org.apache.jackrabbit.vault.validation.spi.impl.AdvancedFilterValidator),
jackrabbit-properties
(org.apache.jackrabbit.vault.validation.spi.impl.AdvancedPropertiesValidator),
jackrabbit-docviewparser
(org.apache.jackrabbit.vault.validation.spi.impl.DocumentViewParserValidator),
jackrabbit-dependencies
(org.apache.jackrabbit.vault.validation.spi.impl.DependencyValidator),
jackrabbit-emptyelements
(org.apache.jackrabbit.vault.validation.spi.impl.EmptyElementsValidator),
jackrabbit-mergelimitations
(org.apache.jackrabbit.vault.validation.spi.impl.MergeLimitationsValidator),
jackrabbit-oakindex
(org.apache.jackrabbit.vault.validation.spi.impl.OakIndexDefinitionValidator),
jackrabbit-packagetype
(org.apache.jackrabbit.vault.validation.spi.impl.PackageTypeValidator),
jackrabbit-primarynodetype
(org.apache.jackrabbit.vault.validation.spi.impl.PrimaryNodeTypeValidator)
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor
'/content/dam' is not covered by any of the specified dependencies nor a valid
root.", filePath=META-INF/vault/filter.xml
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/content/dam' is
not covered by any of the filter rules. Preferably depend on a package that
provides this node or include it in the filter rules!",
filePath=jcr_root/content/dam/.content.xml, nodePath=/content/dam, line=4
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/content' is not
covered by any of the filter rules but that node is a given root (either by a
dependency or by the known roots). Remove that node!",
filePath=jcr_root/content/.content.xml, nodePath=/content, line=4
{code}
Those look all correct.
[~sseifert] Please try again!
was (Author: kwin):
I proposed a fix in http://svn.apache.org/r1869339 and deployed a new snapshot.
[~sseifert] Please try again!
> False warnings for files not being included in the package due to being
> outside of filter roots
> -----------------------------------------------------------------------------------------------
>
> Key: JCRVLT-354
> URL: https://issues.apache.org/jira/browse/JCRVLT-354
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: package maven plugin
> Affects Versions: package-maven-plugin-1.0.4
> Reporter: Stefan Seifert
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: package-maven-plugin-1.1.0
>
>
> the new check introduced in JCRVLT-321 produces false warnings in my case -
> or i do not understand why the warning occurs.
> here is a sample project:
> https://github.com/stefanseifert/filevault-package-maven-plugin-1.0.4-validation-issues/tree/master/content-packages/sample-content
> i can understand these warnings
> {noformat}
> [WARNING] File content-packages\sample-content\jcr_root\.content.xml not
> covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\.content.xml not covered
> by a filter rule and therefore not contained in the resulting package
> {noformat}
> although it's a pity they are reported because usually these .content.xml
> files "above" the filter paths help creating in between nodes when the
> package is extracted and the parent paths of the filter do not exist yet.
> but i do not understand these warnings as the files are definitely included
> in the filter:
> {noformat}
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg.dir\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\_jcr_content\renditions\original
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\_jcr_content\renditions\original.dir\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg.dir\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\_jcr_content\renditions\original
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\_jcr_content\renditions\original.dir\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg.dir\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\_jcr_content\renditions\original
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\_jcr_content\renditions\original.dir\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\myproject1\.content.xml not
> covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File
> content-packages\sample-content\jcr_root\content\myproject1\en\.content.xml
> not covered by a filter rule and therefore not contained in the resulting
> package
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
