[ 
https://issues.apache.org/jira/browse/JCRVLT-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975794#comment-16975794
 ] 

Stefan Seifert commented on JCRVLT-354:
---------------------------------------

looks good, the false warnings are gone!

> False warnings for files not being included in the package due to being 
> outside of filter roots
> -----------------------------------------------------------------------------------------------
>
>                 Key: JCRVLT-354
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-354
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: package maven plugin
>    Affects Versions: package-maven-plugin-1.0.4
>            Reporter: Stefan Seifert
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: package-maven-plugin-1.1.0
>
>         Attachments: 101105_build.log, 
> JCRVLT-354-normalize-windows-paths.patch
>
>
> the new check introduced in JCRVLT-321 produces false warnings in my case - 
> or i do not understand why the warning occurs.
> here is a sample project:
> https://github.com/stefanseifert/filevault-package-maven-plugin-1.0.4-validation-issues/tree/master/content-packages/sample-content
> i can understand these warnings
> {noformat}
> [WARNING] File content-packages\sample-content\jcr_root\.content.xml not 
> covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\.content.xml 
> not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\.content.xml not covered 
> by a filter rule and therefore not contained in the resulting package
> {noformat}
> although it's a pity they are reported because usually these .content.xml 
> files "above" the filter paths help creating in between nodes when the 
> package is extracted and the parent paths of the filter do not exist yet.
> but i do not understand these warnings as the files are definitely included 
> in the filter:
> {noformat}
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\myproject1\.content.xml 
> not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\.content.xml
>  not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg
>  not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg.dir\.content.xml
>  not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\_jcr_content\renditions\original
>  not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\_jcr_content\renditions\original.dir\.content.xml
>  not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\.content.xml
>  not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg
>  not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg.dir\.content.xml
>  not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\_jcr_content\renditions\original
>  not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\_jcr_content\renditions\original.dir\.content.xml
>  not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\.content.xml
>  not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg
>  not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg.dir\.content.xml
>  not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\_jcr_content\renditions\original
>  not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\_jcr_content\renditions\original.dir\.content.xml
>  not covered by a filter rule and therefore not contained in the resulting 
> package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\myproject1\.content.xml not 
> covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File 
> content-packages\sample-content\jcr_root\content\myproject1\en\.content.xml 
> not covered by a filter rule and therefore not contained in the resulting 
> package
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to