[ 
https://issues.apache.org/jira/browse/JCRVLT-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987306#comment-16987306
 ] 

Stefan Seifert commented on JCRVLT-389:
---------------------------------------

i tested the feature with my test project.

this project uses "manual filtering" without the new feature:
https://github.com/stefanseifert/filevault-package-maven-plugin-1.0.4-validation-issues/tree/master/content-packages/ui.apps
pom config: 
https://github.com/stefanseifert/filevault-package-maven-plugin-1.0.4-validation-issues/blob/f4a74028f3f7f0a094a74bbb6b9c82c816afb415/content-packages/ui.apps/pom.xml#L26-L56

the same project on a branch uses the new flag:
https://github.com/stefanseifert/filevault-package-maven-plugin-1.0.4-validation-issues/tree/feature/JCRVLT-389-maven-filtering/content-packages/ui.apps
pom config: 
https://github.com/stefanseifert/filevault-package-maven-plugin-1.0.4-validation-issues/blob/3817cecd3f11b550db4b863a81c12545ae5be89f/content-packages/ui.apps/pom.xml#L27-L40

the result is strange - using the branch the resulting content package has a 
lot of duplicated files on folder positions not included in the source files - 
and the resulting ZIP file has nearly twice the size as the original file with 
the manual filtering.

> Optionally support Maven Filtering during packaging
> ---------------------------------------------------
>
>                 Key: JCRVLT-389
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-389
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>          Components: package maven plugin
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: package-maven-plugin-1.1.0
>
>
> In some cases it would be useful to apply some filtering before a file is 
> being included in the package. Instead of filtering it as separate goal via 
> copy resources this filtering should be optionally supported by the package 
> goal (similar to what the maven-war-plugin offers in 
> https://maven.apache.org/plugins/maven-war-plugin/examples/adding-filtering-webresources.html)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to