[ 
https://issues.apache.org/jira/browse/JCRVLT-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999154#comment-16999154
 ] 

Konrad Windszus edited comment on JCRVLT-389 at 12/18/19 1:31 PM:
------------------------------------------------------------------

[~sseifert] Thanks for the example project. I cannot reproduce the issue with 
duplicate file warnings and neither the issue with the filesize (in both cases 
the result is 179KB). I assume again something with wrong filename separators...
This is an except from the log file
{code}
....
[INFO] --- filevault-package-maven-plugin:1.0.5-SNAPSHOT:package 
(default-package) @ mycompany.myprojectgroup.myproject1.ui.apps ---
[INFO] Using META-INF/vault from 
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/ui.apps/META-INF/vault
[INFO] Packaging content from 
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/ui.apps/jcr_root
[INFO] Apply filtering to FileSet below 
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/ui.apps/jcr_root/apps/epsilon65Project/clientlibs
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, 
i.e. build is platform dependent!
[INFO] Copying 21 resources to 
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/ui.apps/target/filteredFiles
[INFO] Apply filtering to FileSet below 
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/ui.apps/jcr_root/apps/epsilon65Project/core
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, 
i.e. build is platform dependent!
[INFO] Copying 21 resources to 
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/ui.apps/target/filteredFiles
[INFO] Building content-package: 
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/ui.apps/target/myproject1-ui.apps-1.0.0-SNAPSHOT.zip
[INFO] 
[INFO] --- filevault-package-maven-plugin:1.0.5-SNAPSHOT:validate-package 
(default-validate-package) @ mycompany.myprojectgroup.myproject1.ui.apps ---
[INFO] Start validating package 
'/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/ui.apps/target/myproject1-ui.apps-1.0.0-SNAPSHOT.zip'...
[INFO] Using 9 validators for package of type MIXED: jackrabbit-filter 
(org.apache.jackrabbit.vault.validation.spi.impl.AdvancedFilterValidator), 
jackrabbit-properties 
(org.apache.jackrabbit.vault.validation.spi.impl.AdvancedPropertiesValidator), 
jackrabbit-docviewparser 
(org.apache.jackrabbit.vault.validation.spi.impl.DocumentViewParserValidator), 
jackrabbit-dependencies 
(org.apache.jackrabbit.vault.validation.spi.impl.DependencyValidator), 
jackrabbit-emptyelements 
(org.apache.jackrabbit.vault.validation.spi.impl.EmptyElementsValidator), 
jackrabbit-mergelimitations 
(org.apache.jackrabbit.vault.validation.spi.impl.MergeLimitationsValidator), 
jackrabbit-oakindex 
(org.apache.jackrabbit.vault.validation.spi.impl.OakIndexDefinitionValidator), 
jackrabbit-packagetype 
(org.apache.jackrabbit.vault.validation.spi.impl.PackageTypeValidator), 
jackrabbit-primarynodetype 
(org.apache.jackrabbit.vault.validation.spi.impl.PrimaryNodeTypeValidator)
[WARNING] ValidationViolation: "jackrabbit-packagetype: Package of type 'MIXED' 
is legacy. Use one of the other types instead!", 
filePath=META-INF/vault/properties.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor 
'/apps/epsilon65Project' is not covered by any of the specified dependencies 
nor a valid root.", filePath=META-INF/vault/filter.xml
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node 
'/apps/epsilon65Project' is not covered by any of the filter rules. Preferably 
depend on a package that provides this node or include it in the filter 
rules!", filePath=jcr_root/apps/epsilon65Project/.content.xml, 
nodePath=/apps/epsilon65Project, line=3
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/apps' is not 
covered by any of the filter rules but that node is a given root (either by a 
dependency or by the known roots). Remove that node!", 
filePath=jcr_root/apps/.content.xml, nodePath=/apps, line=4
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/' is not 
covered by any of the filter rules but that node is a given root (either by a 
dependency or by the known roots). Remove that node!", 
filePath=jcr_root/.content.xml, nodePath=/, line=6
[INFO] ...
{code}

The warnings look all ok. Can you share the log which is emitted on Windows?


was (Author: kwin):
[~sseifert] Thanks for the example project. I can reproduce the issue with 
duplicate file warnings but I cannot reproduce the issue with the filesize (in 
both cases the result is 179KB). I assume again something with wrong filename 
separators...

> Optionally support Maven Filtering during packaging
> ---------------------------------------------------
>
>                 Key: JCRVLT-389
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-389
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>          Components: package maven plugin
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: package-maven-plugin-1.1.0
>
>
> In some cases it would be useful to apply some filtering before a file is 
> being included in the package. Instead of filtering it as separate goal via 
> copy resources this filtering should be optionally supported by the package 
> goal (similar to what the maven-war-plugin offers in 
> https://maven.apache.org/plugins/maven-war-plugin/examples/adding-filtering-webresources.html)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to