[ 
https://issues.apache.org/jira/browse/JCRVLT-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045323#comment-17045323
 ] 

Konrad Windszus commented on JCRVLT-415:
----------------------------------------

I think the culprit during the export is 
https://github.com/apache/jackrabbit-filevault/blob/6df76ba4a45316a84ec1cd10636296d191a82260/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/aggregator/GenericAggregator.java#L202
 which leads to not generating .content.xml for nt:folders. Alternatively the 
method at 
https://github.com/apache/jackrabbit-filevault/blob/e05e3fc8031eb08f6d0815316ec7fff3367df53c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/AggregateImpl.java#L487
 needs to be tweaked to include the primaryType of the foo node in the 
.content.xml below the test folder. 

> jackrabbit-emptyelements validator reports error for nested folders
> -------------------------------------------------------------------
>
>                 Key: JCRVLT-415
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-415
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: vlt
>    Affects Versions: 3.4.2
>            Reporter: Csaba Varga
>            Priority: Minor
>         Attachments: test.zip, test2.zip
>
>
> When an nt:folder node is present under an orderable node, the 
> "jackrabbit-emptyelements" validator will report an issue (breaking the build 
> with the default settings of the package Maven plugin). I believe this 
> shouldn't be reported as an issue because the AEM Package Manager can 
> generate packages like this. For example, see the attached test.zip file, 
> which was exported on an out-of-the-box AEM 6.5 instance with dummy nodes.
> To reproduce, save test.zip somewhere, then invoke the validation Maven goal 
> in the command like like this:
> {{mvn org.apache.jackrabbit:filevault-package-maven-plugin:validate-package 
> -Dvault.packageToValidate=test.zip}}
> test.zip contains the following very simple node hierarchy:
> {{/}}
>  {{  test (nt:unstructured)}}
>  {{    foo (nt:folder)}}
>  {{      bar (nt:folder)}}
>  {{        baz (sling:OrderedFolder)}}
> The error I'm getting is:
> {{[ERROR] ValidationViolation: "jackrabbit-emptyelements: Found empty nodes: 
> '/test/foo' (in 'test\.content.xml') (used for ordering only) which are 
> included in the filter with mode=merge. Rather use the according 
> include/exclude patterns."}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to