[
https://issues.apache.org/jira/browse/JCRVLT-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17062927#comment-17062927
]
Konrad Windszus edited comment on JCRVLT-421 at 3/19/20, 8:42 PM:
------------------------------------------------------------------
Thanks for the example, still I would argue that at all error messages except
the first are valid concerns. E.g.
https://github.com/stefanseifert/filevault-package-maven-plugin-1.1.2-validation-issues/blob/449e4124afbcff3cfcbcaf7253b9441dde9cd15a/content-packages/sample-content/jcr_root/content/.content.xml#L5
should not be contained in the package at all as it is a sibling(!) of an
ancestor node.
That will never be useful (i.e. never be considered during import) as the
ancestor node `/content` would only be considered if it does not exist yet. In
that case though it cannot have any children though, therefore any ordering on
child nodes are not useful. So to me at least few cases should rather be fixed
in the exporter. WDYT?
The first error is different though.
was (Author: kwin):
Thanks for the example, still I would argue that at least
https://github.com/stefanseifert/filevault-package-maven-plugin-1.1.2-validation-issues/blob/449e4124afbcff3cfcbcaf7253b9441dde9cd15a/content-packages/sample-content/jcr_root/content/.content.xml#L5
should not be contained in the package at all as it is a sibling(!) of an
ancestor node.
That will never be useful (i.e. never be considered during import) as the
ancestor node `/content` would only be considered if it does not exist yet. In
that case though it cannot have any children though, therefore any ordering on
child nodes are not useful. So to me at least few cases should rather be fixed
in the exporter. WDYT?
> filevault-package-maven-plugin 1.1.2: Empty nodes (used for ordering only)
> outside filter lead to error
> --------------------------------------------------------------------------------------------------------
>
> Key: JCRVLT-421
> URL: https://issues.apache.org/jira/browse/JCRVLT-421
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: package maven plugin
> Affects Versions: package-maven-plugin-1.1.2
> Reporter: Stefan Seifert
> Assignee: Konrad Windszus
> Priority: Major
>
> if you download a package from a live repository with a sub path and the
> instance has much more content in sibling paths the package usually contains
> empty node references to the sister nodes to represent the node ordering.
> with filevault-package-maven-plugin 1.1.2 those node references lead to
> validation errors, failing the build.
> to reproduce the problem build this sample project:
> https://github.com/stefanseifert/filevault-package-maven-plugin-1.1.2-validation-issues/tree/master/content-packages/sample-content
> {noformat}
> [ERROR] ValidationViolation: "jackrabbit-filter: Node
> '/content/dam/filevaultsample/jcr:content/folderThumbnail' is not contained
> in any of the filter rules",
> filePath=jcr_root\content\dam\filevaultsample\.content.xml,
> nodePath=/content/dam/filevaultsample/jcr:content/folderThumbnail, line=11,
> column=27
> [INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/content/dam'
> is not covered by any of the filter rules. Preferably depend on a package
> that provides this node or include it in the filter rules!",
> filePath=jcr_root\content\dam\.content.xml
> [ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/rep:policy'
> is not contained in any of the filter rules",
> filePath=jcr_root\content\.content.xml, nodePath=/content/rep:policy, line=5,
> column=18
> [INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/content/dam'
> is not covered by any of the filter rules. Preferably depend on a package
> that provides this node or include it in the filter rules!",
> filePath=jcr_root\content\.content.xml, nodePath=/content/dam, line=6,
> column=11
> [ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/campaigns' is
> not contained in any of the filter rules",
> filePath=jcr_root\content\.content.xml, nodePath=/content/campaigns, line=7,
> column=17
> [ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/projects' is
> not contained in any of the filter rules",
> filePath=jcr_root\content\.content.xml, nodePath=/content/projects, line=8,
> column=16
> [ERROR] ValidationViolation: "jackrabbit-filter: Node
> '/content/experience-fragments' is not contained in any of the filter rules",
> filePath=jcr_root\content\.content.xml,
> nodePath=/content/experience-fragments, line=9, column=28
> [ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/cq:tags' is
> not contained in any of the filter rules",
> filePath=jcr_root\content\.content.xml, nodePath=/content/cq:tags, line=10,
> column=15
> [ERROR] ValidationViolation: "jackrabbit-filter: Node
> '/content/usergenerated' is not contained in any of the filter rules",
> filePath=jcr_root\content\.content.xml, nodePath=/content/usergenerated,
> line=11, column=21
> [ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/launches' is
> not contained in any of the filter rules",
> filePath=jcr_root\content\.content.xml, nodePath=/content/launches, line=12,
> column=16
> [ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/communities'
> is not contained in any of the filter rules",
> filePath=jcr_root\content\.content.xml, nodePath=/content/communities,
> line=13, column=19
> [ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/sites' is not
> contained in any of the filter rules",
> filePath=jcr_root\content\.content.xml, nodePath=/content/sites, line=14,
> column=13
> [ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/forms' is not
> contained in any of the filter rules",
> filePath=jcr_root\content\.content.xml, nodePath=/content/forms, line=15,
> column=13
> [ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/catalogs' is
> not contained in any of the filter rules",
> filePath=jcr_root\content\.content.xml, nodePath=/content/catalogs, line=16,
> column=16
> [ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/screens' is
> not contained in any of the filter rules",
> filePath=jcr_root\content\.content.xml, nodePath=/content/screens, line=17,
> column=15
> [ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/community' is
> not contained in any of the filter rules",
> filePath=jcr_root\content\.content.xml, nodePath=/content/community, line=18,
> column=17
> [INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/content' is
> not covered by any of the filter rules but that node is a given root (either
> by a dependency or by the known roots). Remove that node!",
> filePath=jcr_root\content\.content.xml
> [INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/' is not
> covered by any of the filter rules but that node is a given root (either by a
> dependency or by the known roots). Remove that node!",
> filePath=jcr_root\.content.xml
> {noformat}
> the "[ERROR]" should not occur in this case and did not occur with version
> 1.1.0 of the plugin
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
