kwin commented on a change in pull request #82:
URL: 
https://github.com/apache/jackrabbit-filevault/pull/82#discussion_r430169330



##########
File path: 
vault-rcp/src/main/java/org/apache/jackrabbit/vault/rcp/impl/RcpTaskImpl.java
##########
@@ -211,18 +210,22 @@ public STATE getState() {
         return state;
     }
 
+    @Override
     public RepositoryAddress getSource() {
         return src;
     }
 
+    @Override
     public String getDestination() {
         return dst;
     }
 
+    @Override
     public void setRecursive(boolean b) {
         this.recursive = b;

Review comment:
       I will make recursive final

##########
File path: 
vault-rcp/src/main/java/org/apache/jackrabbit/vault/rcp/impl/RcpTaskImpl.java
##########
@@ -211,18 +210,22 @@ public STATE getState() {
         return state;
     }
 
+    @Override
     public RepositoryAddress getSource() {
         return src;
     }
 
+    @Override
     public String getDestination() {
         return dst;
     }
 
+    @Override
     public void setRecursive(boolean b) {
         this.recursive = b;
     }
 
+    @Override
     public void addExclude(String exclude) throws ConfigurationException {

Review comment:
       I will make the filter final




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to