[
https://issues.apache.org/jira/browse/JCRVLT-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117679#comment-17117679
]
Konrad Windszus edited comment on JCRVLT-440 at 5/27/20, 2:21 PM:
------------------------------------------------------------------
The correct fix is to not catch any exceptions in {{InstallHookProcessor}}.
That way the error is correctly logged and leads to the correct error on
client-side.
[~tripod] WDYT?
was (Author: kwin):
The correct fix is to not catch any exceptions in {{InstallHookProcessor}}.
That way the error is correctly logged and lead to the correct error on
client-side.
[~tripod] WDYT?
> Do not treat Throwables differently than PackageExceptions in Hooks
> -------------------------------------------------------------------
>
> Key: JCRVLT-440
> URL: https://issues.apache.org/jira/browse/JCRVLT-440
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Affects Versions: 3.4.4
> Reporter: Konrad Windszus
> Priority: Major
> Fix For: 3.4.6
>
>
> Currently only {{PackageExceptions}} in hooks leads to package installation
> failures. All {{Throwable}} s are basically silently ignored (with just a
> small warning) at
> https://github.com/apache/jackrabbit-filevault/blob/38ab44e815e114479dcf06dabfbfd5a1898a192f/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/InstallHookProcessorImpl.java#L152.
> IMHO all exceptions should lead to package installation failures which are
> also propagated to the client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
