[
https://issues.apache.org/jira/browse/JCRVLT-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143565#comment-17143565
]
Konrad Windszus commented on JCRVLT-448:
----------------------------------------
[~tripod] It will only close it via the wrapped JAR output stream
(https://github.com/apache/jackrabbit-filevault/blob/70dfb76e5c5aef46866b6e31570ce6cea9c9ccd7/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/JarExporter.java#L141)
but not if {{open}} has never been called. Clearly this is an edge case as at
least for {{export}} the {{open}} method is called quite early. Still it would
be safer if in case no JarOutputStream has been created yet to also close the
unwrapped output stream. WDYT?
> JcrPackageManagerImpl.rewrap and assemble do not close passed output stream
> ---------------------------------------------------------------------------
>
> Key: JCRVLT-448
> URL: https://issues.apache.org/jira/browse/JCRVLT-448
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: vlt
> Affects Versions: 3.4.4
> Reporter: Konrad Windszus
> Priority: Critical
> Fix For: 3.4.6
>
>
> Despite their javadoc saying otherwise both
> https://github.com/apache/jackrabbit-filevault/blob/70dfb76e5c5aef46866b6e31570ce6cea9c9ccd7/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/PackageManagerImpl.java#L205
> and
> https://github.com/apache/jackrabbit-filevault/blob/70dfb76e5c5aef46866b6e31570ce6cea9c9ccd7/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/PackageManagerImpl.java#L132
> do not(!) close the passed output stream.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
