[
https://issues.apache.org/jira/browse/JCR-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151106#comment-17151106
]
Konrad Windszus edited comment on JCR-4536 at 7/3/20, 9:03 PM:
---------------------------------------------------------------
1) Since the parameter needs to be given for each call to either
https://github.com/apache/jackrabbit/blob/0f0807d25283b8786d800dcc41821443f43c2f82/jackrabbit-spi2dav/src/main/java/org/apache/jackrabbit/spi2davex/Spi2davexRepositoryServiceFactory.java#L77
or
https://github.com/apache/jackrabbit/blob/trunk/jackrabbit-spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/Spi2davRepositoryServiceFactory.java#L85
I don't really see the point of additionally restrict the hosts. It affects
only one connection anyways....
It's an opt in feature, so it is never enabled by default
Regarding tests: That would require setting up some real server, are there any
examples of this already in the codebase?
WDYT about the {{maximumHttpConnections}}. IMHO this should also be
encapsulated in {{ConnectionOptions}} as well. Maybe we can continue the
discussion directly on the PR. That makes the context much clearer.
was (Author: kwin):
1) Since the parameter needs to be given for each call to either
https://github.com/apache/jackrabbit/blob/0f0807d25283b8786d800dcc41821443f43c2f82/jackrabbit-spi2dav/src/main/java/org/apache/jackrabbit/spi2davex/Spi2davexRepositoryServiceFactory.java#L77
or
https://github.com/apache/jackrabbit/blob/trunk/jackrabbit-spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/Spi2davRepositoryServiceFactory.java#L85
I don't really see the point of additionally restrict the hosts. It affects
only one connection anyways....
It's an opt in feature, so it is never enabled by default
Regarding tests: That would require setting up some real server, are there any
examples of this already in the codebase?
WDYT about the `maximumHttpConnections`. IMHO this should also be encapsulated
in `ConnectionOptions`. Maybe we can continue the discussion directly on the
PR. That makes the context much clearer.
> Feature/enable insecure https host
> ----------------------------------
>
> Key: JCR-4536
> URL: https://issues.apache.org/jira/browse/JCR-4536
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-spi2dav
> Reporter: Max Barrass
> Assignee: Konrad Windszus
> Priority: Major
>
> Adding support for insecure parameter to allow access to https with invalid
> certs.
> Enabling optional support for expired ssl certs when using https on
> development server with self generated certificates.
> Pull request already created and ready for review
> [https://github.com/apache/jackrabbit/pull/88]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
