kwin commented on a change in pull request #92:
URL: https://github.com/apache/jackrabbit/pull/92#discussion_r455784043
##########
File path:
jackrabbit-spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/Spi2davRepositoryServiceFactory.java
##########
@@ -136,22 +140,6 @@ public RepositoryService createRepositoryService(Map<?, ?>
parameters) throws Re
// ignore, use default
}
}
-
- // max connections config
- int maximumHttpConnections = 0;
- param = parameters.get(PARAM_MAX_CONNECTIONS);
- if (param != null) {
- try {
- maximumHttpConnections = Integer.parseInt(param.toString());
- } catch ( NumberFormatException e ) {
- // using default
- }
- }
-
- if (maximumHttpConnections > 0) {
- return new RepositoryServiceImpl(uri, idFactory, nameFactory,
pathFactory, vFactory, itemInfoCacheSize, maximumHttpConnections);
- } else {
- return new RepositoryServiceImpl(uri, idFactory, nameFactory,
pathFactory, vFactory, itemInfoCacheSize);
- }
+ return new RepositoryServiceImpl(uri, idFactory, nameFactory,
pathFactory, vFactory, itemInfoCacheSize,
ConnectionOptions.fromServiceFactoryParameters("org.apache.jackrabbit.spi2dav",
parameters));
Review comment:
no dynamic prefix should be used for connection parameters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
