[
https://issues.apache.org/jira/browse/JCRVLT-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175745#comment-17175745
]
Konrad Windszus edited comment on JCRVLT-464 at 8/11/20, 5:54 PM:
------------------------------------------------------------------
The relevant property {{maven.version}} is overwritten for the Maven plugin:
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/725276dbb3f51b8845aa80eac4beeb2bcdd1b127/pom.xml#L42.
As that is used for the enforcer rules as well
(https://github.com/apache/jackrabbit-filevault/blob/98a1ae33045762c071bfdb10a3527aa9c6d77971/parent/pom.xml#L298)
I would rather assume that there is a bug in the {{versions-maven-plugin}}
detection.
Or do you see any mistakes in the poms, [~sseifert]?
To me it seems that this logic is wrong:
https://github.com/mojohaus/versions-maven-plugin/blob/5ad79bd3c38a9b709b3e456b3939bbed645b6684/src/main/java/org/codehaus/mojo/versions/RequiredMavenVersionFinder.java#L31
was (Author: kwin):
The relevant property {{maven.version}} is overwritten for the Maven plugin:
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/725276dbb3f51b8845aa80eac4beeb2bcdd1b127/pom.xml#L42.
As that is used for the enforcer rules as well
(https://github.com/apache/jackrabbit-filevault/blob/98a1ae33045762c071bfdb10a3527aa9c6d77971/parent/pom.xml#L298)
I would rather assume that there is a bug in the {{versions-maven-plugin}}
detection.
Or do you see any mistakes in the poms, [~sseifert]?
> jackrabbit-filevault-package-maven-plugin requires Maven 3.6.1 although not
> intended
> ------------------------------------------------------------------------------------
>
> Key: JCRVLT-464
> URL: https://issues.apache.org/jira/browse/JCRVLT-464
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: package maven plugin
> Affects Versions: package-maven-plugin-1.1.4
> Reporter: Stefan Seifert
> Assignee: Konrad Windszus
> Priority: Major
>
> the latest version of {{jackrabbit-filevault-package-maven-plugin}} is
> detected by {{versions-maven-plugin}} to required Maven 3.6.1:
> {noformat}
> [INFO] --- versions-maven-plugin:2.8.1:display-plugin-updates (default-cli) @
> io.wcm.maven.aem-global-parent ---
> [INFO]
> [INFO] The following plugin updates are available:
> [INFO] org.apache.jackrabbit:filevault-package-maven-plugin 1.1.0 -> 1.1.2
> [INFO]
> [INFO] All plugins have a version specified.
> [INFO]
> [INFO] Project inherits minimum Maven version as: 3.6.0
> [INFO] Plugins require minimum Maven version of: 3.6.0
> [INFO]
> [INFO] No plugins require a newer version of Maven than specified by the pom.
> [INFO]
> [INFO] Require Maven 3.6.1 to use the following plugin updates:
> [INFO] org.apache.jackrabbit:filevault-package-maven-plugin 1.1.0 -> 1.1.4
> {noformat}
> but this does not seem to be intended as the pom itself defines Maven 3.3.9
> as prerequisite:
> https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/725276dbb3f51b8845aa80eac4beeb2bcdd1b127/pom.xml#L42
> with version 1.1.4 the parent pom was switched to
> {{org.apache.jackrabbit.vault:parent}} 3.4.6, and this defines
> {{maven.version}} to 3.6.1 and some additional enforcer rules. it seems the
> {{versions-maven-plugins}} gets this version information from the enforcer
> rules and expects 3.6.1 as minimum required version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
