[
https://issues.apache.org/jira/browse/JCRVLT-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175813#comment-17175813
]
Stefan Seifert commented on JCRVLT-464:
---------------------------------------
i suppose the intention of the logic in the versions-maven-plugin besides
simple inheritance is to allow to step in additional enforcer rules defined in
parent poms as well. but how it is implemented the highest required maven
version wins wherever it is defined in the parent hierarchy chain.
but it is debatable if the logic is really wrong. after all if the parent has
e.g. a couple of plugins defined that required maven 3.6.1 these plugins also
get active in the child pom, independently of what min maven version it itself
defines. i would tend to accept that the current logic of versions-maven-plugin
is on the "safe side" and is unlikely to be changed.
leaving the question what to do with this issue - should the min version of
maven 3.6.1 be accepted (should not be a problem for developers - but CI/CD
systems might be slower in picking up new version - adobe cloud manager is
still in 3.6.0 currently...)
> jackrabbit-filevault-package-maven-plugin requires Maven 3.6.1 although not
> intended
> ------------------------------------------------------------------------------------
>
> Key: JCRVLT-464
> URL: https://issues.apache.org/jira/browse/JCRVLT-464
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: package maven plugin
> Affects Versions: package-maven-plugin-1.1.4
> Reporter: Stefan Seifert
> Assignee: Konrad Windszus
> Priority: Major
>
> the latest version of {{jackrabbit-filevault-package-maven-plugin}} is
> detected by {{versions-maven-plugin}} to required Maven 3.6.1:
> {noformat}
> [INFO] --- versions-maven-plugin:2.8.1:display-plugin-updates (default-cli) @
> io.wcm.maven.aem-global-parent ---
> [INFO]
> [INFO] The following plugin updates are available:
> [INFO] org.apache.jackrabbit:filevault-package-maven-plugin 1.1.0 -> 1.1.2
> [INFO]
> [INFO] All plugins have a version specified.
> [INFO]
> [INFO] Project inherits minimum Maven version as: 3.6.0
> [INFO] Plugins require minimum Maven version of: 3.6.0
> [INFO]
> [INFO] No plugins require a newer version of Maven than specified by the pom.
> [INFO]
> [INFO] Require Maven 3.6.1 to use the following plugin updates:
> [INFO] org.apache.jackrabbit:filevault-package-maven-plugin 1.1.0 -> 1.1.4
> {noformat}
> but this does not seem to be intended as the pom itself defines Maven 3.3.9
> as prerequisite:
> https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/725276dbb3f51b8845aa80eac4beeb2bcdd1b127/pom.xml#L42
> with version 1.1.4 the parent pom was switched to
> {{org.apache.jackrabbit.vault:parent}} 3.4.6, and this defines
> {{maven.version}} to 3.6.1 and some additional enforcer rules. it seems the
> {{versions-maven-plugins}} gets this version information from the enforcer
> rules and expects 3.6.1 as minimum required version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
