stefan-egli commented on a change in pull request #247:
URL: https://github.com/apache/jackrabbit-oak/pull/247#discussion_r481244783
##########
File path:
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentSweeper2.java
##########
@@ -0,0 +1,357 @@
+/*
Review comment:
Agree, and I was aware of this. However, I did this on purpose as
indicated in the class comment. The alternative would have been to reuse
NodeDocumentSweeper - with the risk or cost that any future change on that
class would have to be carefully crafted to avoid any side-effects on
NodeDocumentSweeper2 behaviour. I considered this future risk as higher versus
the code-duplication. Wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
