anchela edited a comment on pull request #249: URL: https://github.com/apache/jackrabbit-oak/pull/249#issuecomment-688804114
@Vinod-holani , had a quick look at the change, because it affects a class in the security area. i cannot comment on the usage of blobaccessprovider in the userconfiguration (not really familiar with the blob-handling in oak). but i have a general comment: i would very much appreciate, if your patch would come with tests illustrating the problem you are aiming to fix. it should fail without the patch and obviously pass with the patch applied. thanks for updating your PR with tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
