[ 
https://issues.apache.org/jira/browse/JCRVLT-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated JCRVLT-477:
----------------------------------
    Flags: Patch

PR: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/45

it seems the resourceEncoding parameter introduced in JCRVLT-389 was not used 
at all. the PR fixes the problem for me and resource filtering still working as 
expected.

> package maven plugin filtering complains about platform encoding although 
> project.build.sourceEncoding is set
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: JCRVLT-477
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-477
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: package maven plugin
>    Affects Versions: package-maven-plugin-1.1.4
>            Reporter: Stefan Seifert
>            Priority: Major
>
> when building this content package project:
> https://github.com/stefanseifert/filevault-package-maven-plugin-validation-issues/tree/master/content-packages/ui.apps
> this warning is reported:
> {noformat}
> [INFO] Apply filtering to FileSet below 
> D:\Develop\github\filevault-package-maven-plugin-validation-issues\content-packages\ui.apps\target\classes\apps\filevaultsample\clientlibs
> [WARNING] Using platform encoding (Cp1252 actually) to copy filtered 
> resources, i.e. build is platform dependent!
> [INFO] Using 'null' encoding to copy filtered properties files.
> [INFO] Copying 20 resources to 
> D:\Develop\github\filevault-package-maven-plugin-validation-issues\content-packages\ui.apps\target\filteredFiles\jcr_root\apps\filevaultsample\clientlibs
> [INFO] Apply filtering to FileSet below 
> D:\Develop\github\filevault-package-maven-plugin-validation-issues\content-packages\ui.apps\target\classes\apps\filevaultsample\core
> [WARNING] Using platform encoding (Cp1252 actually) to copy filtered 
> resources, i.e. build is platform dependent!
> {noformat}
> it complains twice about the missing encoding configuration.
> following the documentation from
> http://jackrabbit.apache.org/filevault-package-maven-plugin/package-mojo.html#resourceEncoding
> the default for the encoding is the maven property 
> {{project.build.sourceEncoding}}
> which is configured in one of the parent POMs of this project (visible e.g. 
> when using {{help:effective-pom}}).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to