[ 
https://issues.apache.org/jira/browse/JCRVLT-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273500#comment-17273500
 ] 

Konrad Windszus edited comment on JCRVLT-499 at 1/29/21, 9:12 AM:
------------------------------------------------------------------

The reason is that the {{JcrPackageDefinitionImpl.writeProperties()}} directly 
acts on the low-level {{Properties}} instead of {{PackageProperties}}. I think 
it would make sense to instead rely on {{PackageProperties}} as this is doing 
the parsing correctly.


was (Author: kwin):
The reason is that the `JcrPackageDefinitionImpl.writeProperties` directly acts 
on the low-level `Properties` instead of `PackageProperties`. I think it would 
make sense to instead rely on `PackageProperties` as this is doing the parsing 
correctly.

> JcrPackageDefinitionImpl:getDate does not fully support  ISO8601 format
> -----------------------------------------------------------------------
>
>                 Key: JCRVLT-499
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-499
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: vlt
>            Reporter: Ievgen Nedoviesov
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: 3.4.10
>
>
> According to doc 
> [http://jackrabbit.apache.org/filevault/properties.html#Entries] property 
> "created" supports  
> [ISO8601|https://jackrabbit.apache.org/api/2.12/org/apache/jackrabbit/util/ISO8601.html].
>  
>  But it does not support a designator "Z", which is valid according to 
> ISO8601.
>  The following strings from "created" property give the following results:
>  {{2021-01-28T06:20:18.805+01:00}} => parsed and {{jcr:created}} is set
>  {{2021-01-27T16:21:27.034Z}} => fails parsing and {{jcr:created}} is not set
> Root issue is that string is parsed before passing it to ISO8601.parse()
> https://github.com/apache/jackrabbit-filevault/blob/master/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageDefinitionImpl.java#L461-L479



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to