dulceanu commented on a change in pull request #280:
URL: https://github.com/apache/jackrabbit-oak/pull/280#discussion_r586322526
##########
File path:
oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/DefaultSegmentWriter.java
##########
@@ -132,14 +134,16 @@ public DefaultSegmentWriter(
@NotNull SegmentIdProvider idProvider,
@Nullable BlobStore blobStore,
@NotNull WriterCacheManager cacheManager,
- @NotNull WriteOperationHandler writeOperationHandler
+ @NotNull WriteOperationHandler writeOperationHandler,
+ int binariesInlineThreshold
) {
this.store = checkNotNull(store);
this.reader = checkNotNull(reader);
this.idProvider = checkNotNull(idProvider);
this.blobStore = blobStore;
this.cacheManager = checkNotNull(cacheManager);
this.writeOperationHandler = checkNotNull(writeOperationHandler);
+ this.binariesInlineThreshold = binariesInlineThreshold;
Review comment:
Yes, I think you're right. I moved the checks here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
